Conversation
|
Hey, thanks for the PR. Could you sign the CLA when you get a chance so we can review it? |
|
Thanks for the reminder. I have already signed the CLA, but CLA Assistant is still showing it as pending on this PR. I’ll retry its recheck flow; if it continues to block review, please let me know what additional step is needed. I also added the suggested one-line Unreleased changelog entry in the latest commit. |
|
The exact source commits are incorporated and their validation/issue mapping is preserved. Superseded by #1632. The aggregate remains draft pending the remaining batch and final checks; this does not indicate a merge into dev. |
|
Thanks @hy3560 will be going in with next Dev. |
|
Reopening: the second consolidation is now restricted to Santosh-authored PRs. This contributor PR will remain standalone; its bootstrap inclusion is being removed from #1632. The earlier superseded closure no longer applies. |
What changed
docs/benchmarks/performance/measure-cli.sh.Fixes #1446
How it was checked
go build ./...— passed (Windows, Go 1.26.5).go test ./docs/benchmarks/performance -count=1andgo vet ./docs/benchmarks/performance— passed.measure-cli.sh --helpexamples from the repository root with Git Bash — usage printed.git diff --check— passed.The broader Windows checks are not fully clean:
go vet ./...and some manual/law test packages reference Unix-onlysyscall.Kill/unix.Flock; separate existing UI/law assertions also fail on this checkout. GNUmakeis not installed here, so I could not run the repository wrappermake pr-ready. These failures are outside the changed files; CI on Linux is still needed.