Skip to content

docs(benchmarks): fix measure-cli script path - #1498

Open
hy3560 wants to merge 2 commits into
Agent-Field:devfrom
hy3560:fix/1446-measure-cli-path
Open

hy3560 wants to merge 2 commits into
Agent-Field:devfrom
hy3560:fix/1446-measure-cli-path

Conversation

@hy3560

@hy3560 hy3560 commented Sep 25, 2026

Copy link
Copy Markdown

What changed

  • Point the README and script usage examples to docs/benchmarks/performance/measure-cli.sh.
  • Add a Go regression test that verifies the local script paths in both examples resolve.

Fixes #1446

How it was checked

  • go build ./... — passed (Windows, Go 1.26.5).
  • go test ./docs/benchmarks/performance -count=1 and go vet ./docs/benchmarks/performance — passed.
  • Ran both measure-cli.sh --help examples from the repository root with Git Bash — usage printed.
  • git diff --check — passed.

The broader Windows checks are not fully clean: go vet ./... and some manual/law test packages reference Unix-only syscall.Kill / unix.Flock; separate existing UI/law assertions also fail on this checkout. GNU make is not installed here, so I could not run the repository wrapper make pr-ready. These failures are outside the changed files; CI on Linux is still needed.

@CLAassistant

CLAassistant commented Sep 25, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@santoshkumarradha

Copy link
Copy Markdown
Member

Hey, thanks for the PR. Could you sign the CLA when you get a chance so we can review it?

@hy3560

hy3560 commented Sep 25, 2026

Copy link
Copy Markdown
Author

Thanks for the reminder. I have already signed the CLA, but CLA Assistant is still showing it as pending on this PR. I’ll retry its recheck flow; if it continues to block review, please let me know what additional step is needed. I also added the suggested one-line Unreleased changelog entry in the latest commit.

@santoshkumarradha santoshkumarradha added hygiene Tests, laws, dead code, duplication — no person-facing change area:tests The suite itself — flakes, harnesses, laws, CI reds labels Sep 27, 2026
@santoshkumarradha santoshkumarradha added this to the Tests & tooling milestone Sep 27, 2026
santoshkumarradha added a commit that referenced this pull request Sep 27, 2026
@santoshkumarradha

Copy link
Copy Markdown
Member

The exact source commits are incorporated and their validation/issue mapping is preserved. Superseded by #1632. The aggregate remains draft pending the remaining batch and final checks; this does not indicate a merge into dev.

@santoshkumarradha

Copy link
Copy Markdown
Member

Thanks @hy3560 will be going in with next Dev.

@santoshkumarradha

Copy link
Copy Markdown
Member

Reopening: the second consolidation is now restricted to Santosh-authored PRs. This contributor PR will remain standalone; its bootstrap inclusion is being removed from #1632. The earlier superseded closure no longer applies.

santoshkumarradha added a commit that referenced this pull request Sep 27, 2026
This reverts commit 576dc9a, reversing
changes made to 837b2b0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:tests The suite itself — flakes, harnesses, laws, CI reds hygiene Tests, laws, dead code, duplication — no person-facing change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The performance README points to a measure script at the wrong path

3 participants