Skip to content

tui3: an air row under the nav — proper spacing between the top header rows - #1509

Closed
santoshkumarradha wants to merge 2 commits into
devfrom
task/top-nav
Closed

santoshkumarradha wants to merge 2 commits into
devfrom
task/top-nav

Conversation

@santoshkumarradha

@santoshkumarradha santoshkumarradha commented Sep 25, 2026 •

Copy link
Copy Markdown
Member

Header spacing

Navigation and tabs have clear spacing.

Header spacing


The change: proper spacing between the top header rows

The two top rows of the head — the nav row (the wordmark, the places, the machine's
pulse on the far end) and the chat strip — used to sit directly on top of each
other. This PR inserts one full blank row of air between them. The head is now
five rows on every page: nav → air → strip → rule → blank (placeHeadRows
4→5, tabStripRow 1→2), unchanged at every size on a place and on a
conversation alike, so walking between pages still moves nothing a person has found.

The air row is exactly the branch's own sanctioned path — placebodies.go already
said a fifth head row is "a change to this constant and to nothing else" — and
now it lands. The welcome screen's minimum-height reserve gives one row back to
the head, and the tests' frames grow one row to keep charging it.

Tests and review

  • go test ./internal/tui3/ — green, all sizes from the head's invariants:
    the strip on row two under the air row; the head closes with a rule and a blank;
    every place spends the same five rows.
  • go build ./... and go vet ./internal/tui3/ — clean.
  • Review Pass 1 (defects & contracts): the head's row invariants are asserted
    at every width/height in head_test.go and topnav_test.go; zero regressions.
  • Review Pass 2 (architecture & craft): no new abstraction, no dead code;
    comments and docs updated to the five-row vocabulary everywhere; the docs'
    design references record the visual intent.

—
Drafted with CodeAF · reviewed and owned by the author

header-preview.mp4

@santoshkumarradha
santoshkumarradha marked this pull request as ready for review September 25, 2026 15:58
@santoshkumarradha

Copy link
Copy Markdown
Member Author

Visual Proof: Live TUI on DGX Spark (SSH)

Spark TUI Header Spacing

Captured live from DGX Spark (spark) running the built branch in tmux (3008×944):

  • Row 1: Top navigation line (>● codeaf home teams chats sessions spend settings)
  • Row 2: Blank air row (clear vertical breathing room)
  • Row 3: Tab strip (+)
  • Row 4: Divider rule
  • Row 5: Margin blank row

Test suite: go test ./internal/tui3/... passed green in 38.5s.

drafted with CodeAF

@santoshkumarradha

Copy link
Copy Markdown
Member Author

Live TUI Header Spacing on Spark (tmux)

Here is the live capture of the TUI running in a tmux session (codeaf-demo) on Spark with the new header spacing:

Live Spark tmux Screenshot

Observed layout:

  1. Row 1 (Nav bar): >● codeaf home teams chats sessions spend settings + $4.26 / $500 · fri 12:10pm
  2. Row 2 (Air row): Deliberate blank spacer row between nav and chat strip providing clear visual breathing room.
  3. Row 3 (Chat strip): + icon / tab strip.
  4. Row 4 (Rule): Horizontal rule dividing header from frame body.
  5. Bottom: Active tmux status bar [codeaf-demo] 0:codeaf-spacing* & "spark" 12:10 25-Sep-26.

—
drafted with CodeAF

@santoshkumarradha

Copy link
Copy Markdown
Member Author

Authentic Graphical Window Capture (tmux + live codeaf TUI)

Updated docs/design/spark-tmux-live-header.png with an authentic 2× Retina graphical macOS Terminal window screenshot hosting the tmux session with the live codeaf TUI:

Live Terminal Tmux Screenshot

Confirmed visual characteristics:

  • Native window chrome (traffic lights, drop shadow, window title user — command — process — profile ▸ tmux — 213×64).
  • Row 1: Navigation bar (>● codeaf home teams chats sessions 18 spend settings + pulse $10.23 / $500 · fri 1:25pm).
  • Row 2: Clear, deliberate blank spacer row of air (~20.5px height) providing proper breathing room.
  • Row 3: Active chat tab strip (teams ▾, ◐ investigating issue 1508 providerword law tests, +, ■ All).
  • Row 4: Horizontal dividing rule line spanning the window width.
  • Bottom: Active green tmux status bar ([live-tui-0:codeaf-local* / "codeaf" 13:25 25-Sep-26).

—
drafted with CodeAF

@santoshkumarradha

Copy link
Copy Markdown
Member Author

@AbirAbbas this PR is ready for review.

Port of the five-row head onto dev's conditional-strip architecture:
the strip only draws while a conversation is in front, so the air row
is the head's own. A place spends four rows (nav, air, rule, blank:
placeHeadRows 3→4); a conversation five (the strip back in its place
between the air row and the rule: chatHeadRows = placeHeadRows + 1,
tabStripRow = 2). Design references and the live spark capture ride
along under docs/design/.
Assisted-by: CodeAF (gemini-3.8-flash-high)
Co-Authored-By: CodeAF <267109073+agentfield-bot@users.noreply.github.com>
@santoshkumarradha

Copy link
Copy Markdown
Member Author

@AbirAbbas this is review ready

@santoshkumarradha santoshkumarradha added this to the Chat & connections milestone Sep 27, 2026
@santoshkumarradha santoshkumarradha added bug Something the code does that it should not area:chat The v3 surface a person sits in front of (internal/tui3) sev:papercut A wording, a hint, a small wrongness that costs a moment labels Sep 27, 2026
@santoshkumarradha

Copy link
Copy Markdown
Member Author

Integrated at exact reviewed head a08b1bb into Santosh/dev and superseded by draft #1627. Source description and validation are preserved at #1627 (comment). The combined PR remains draft for final acceptance. No source branch was deleted.

AbirAbbas added a commit that referenced this pull request Sep 28, 2026
* session: the waiting sentence and its sign-in reason land together

A connect offer published the waiting lane before the desk held the
sign-in sentence, so a reader could see that a person is needed with
an empty reason. The row is banked while the agent lock is held, and
the lane is filled before that lock is released.

* changes: note for #1502

* tui3: an air row under the nav — the head grows a row of its own

Port of the five-row head onto dev's conditional-strip architecture:
the strip only draws while a conversation is in front, so the air row
is the head's own. A place spends four rows (nav, air, rule, blank:
placeHeadRows 3→4); a conversation five (the strip back in its place
between the air row and the rule: chatHeadRows = placeHeadRows + 1,
tabStripRow = 2). Design references and the live spark capture ride
along under docs/design/.

* docs(changelog): add unreleased changelog entry for PR #1509

Assisted-by: CodeAF (gemini-3.8-flash-high)
Co-Authored-By: CodeAF <267109073+agentfield-bot@users.noreply.github.com>

* session: the transcript keeps the person's words when a turn carries skills (#1504)

The skills block rides the copy the model reads; the record the surfaces
draw keeps the person's own words, and the dim skills-carried line is the
one visible channel. Adds the end-to-end regression test through the real
chat door, and lands the full internal/session suite green: the lane-news
test helper no longer hands an earlier test's held sighting to the first
reader of the next, and the ignored-folder receipt test wants the
canonical spelling the receipt actually prints.

* tui3: enter takes the answer the pointer stands on, on a standing card (#1506)

The standing card's box is its correction lane, and the InputText give-up
read that as the whole question: enter over an empty box did nothing even
with the pointer standing on an answer, and the key table's own reading
offered enter only where the asker recommended something. Both give-ups
now yield to a pointer that stands on an option on a question that has a
pick to take — a choice or a judgement — while a connect key offer keeps
its own law: one answer, the way out, taken by a digit, and enter means
the words. The walk was already there; enter just never followed it.

* style: gofmt internal/tui3/standingenter_test.go

Assisted-by: CodeAF (gemini-3.8-flash-high)
Co-Authored-By: CodeAF <267109073+agentfield-bot@users.noreply.github.com>

* docs: write the change down for 1506

* session: the transcript test settles the chatlog before reading the store back

The end-to-end test read brain.Messages straight after the turn's events
closed, but the transcript reaches the store through the batching chat
log: the read raced the writer and on CI lost, finding an empty thread.
Close the log first, the way chatlog_test reads its thread back.

* chat: groom the standing card ask and its yes clause

The lead said "wants to keep an eye on" on every standing card, which was
wrong about most of them: a one-off reminder watches nothing, and a rule that
never wakes watches nothing either. The lead now says what a yes binds —
"wants to set this up" — for every kind.

The yes clause beside the chip promised "it keeps happening until you stop
it" on cards whose item runs once at a moment and then retires. The clause
now reads the item: at-things get "it happens at the time, and then it
retires", and every other kind keeps the old clause.

The manual pages that quote the card move with it, and the tests that assert
the lead's words say the new words.

* docs(changelog): add unreleased entry for PR #1520

* feat(session): plan-born task worker briefs carry standing project orders (#1549)

* docs(changes): fix surface tag to chat and engine for #1549

* plandb: check terminal status before ownership check in Done, prune search guidance

In Store.Done(), check if task is already terminal before checking requireOwner().
When a task is cancelled upstream, ClaimedBy is cleared or empty, which previously
caused Done to fail obscurely with 'task is not claimed'. Checking terminal status
first reports an explicit and actionable error: 'task is already terminal (cancelled)'.

Also update bashworker prompt guidance to prune heavy directories when running find,
preventing workers from freezing across deep trees.

Fixes #1561

Assisted-by: CodeAF (gemini-3.8-flash-high)
Co-Authored-By: CodeAF <267109073+agentfield-bot@users.noreply.github.com>

* fix(tui3): task proposal countdown handles keypress and avoids starting declined task (#1547)

* session: fall back to project place workspace when workspace is non-repository

When a session operates with workspace outside a repository (e.g. user home
folder ~ in a team manager session), task ground derivation would fall through
to taskGroundNothing at dir: ~, leading spawned tasks to inherit ~ as ground.
Workers looking for repository docs like docs/design/plandb-cli/ would then
fail to locate them and launch unpruned find commands across the entire home drive.

Fall back to a.config.Place.Workspace when workspace has no repository root,
preserving taskGroundStandingIn on the intended project repository.

Fixes #1561

Assisted-by: CodeAF (gemini-3.8-flash-high)
Co-Authored-By: CodeAF <267109073+agentfield-bot@users.noreply.github.com>

* tui3: allow slash command completion to execute bare /task, /redo, and /workspace immediately

Fixes #1548

* fix(session): enforce daily spend rail on interactive turns and task delegations (#1546)

* docs(changes): add changelog entry for PR 1562

Assisted-by: CodeAF (gemini-3.8-flash-high)
Co-Authored-By: CodeAF <267109073+agentfield-bot@users.noreply.github.com>

* prompts: restore bashworker prompt to keep prompt size under 16 KiB

Assisted-by: CodeAF (gemini-3.8-flash-high)
Co-Authored-By: CodeAF <267109073+agentfield-bot@users.noreply.github.com>

* fix(teams): manager conversation initialization, handle fallback, and approval posture inheritance (#1551)

* docs(changes): state the stale belief as a claim with a full stop for #1549

* fix(session): exempt task workers and errands from interactive rail block (#1546)

* jobs: bound the disk spool and let the footer admit the truncation

A background job's log used to grow without limit: every byte the job
wrote went to one <id>.log forever, a single huge Write grew the
in-memory ring by its whole length before trimming, and a failed or
short or unclosable spool write was swallowed whole. A watcher that
prints for a week filled the disk at whatever rate it printed.

The spool is now a window: at most jobSpoolChunks chunks of
jobSpoolChunkBytes (4MB) on disk — <id>.log live, <id>.log.1 kept —
rotated by rename and never rewritten per write, the chunk beyond the
window deleted and counted. One huge Write spools in chunk-sized
pieces and hands only its newest 64KB to the ring, so no temporary
grows to match it. A failed, short or failed-to-close spool write
records one notice, stops the retries, and never stops the drain or
kills the job.

Every footer a model reads — jobs output and the completion note alike
— stays honest about the bound: full log while the file is everything
the job wrote, the truncation or the failure named beside the path
where it is not. The manual's promises of the whole log, the jobs tool
description and PERF.md move with it.

Retained output stays addressable by the read tool exactly as before.
Aggregate retention across jobs and search exclusion are deliberately
not in this change. Issue #1599.

Assisted-by: CodeAF
Co-Authored-By: CodeAF <267109073+agentfield-bot@users.noreply.github.com>

* docs: point 1549 changelog entry at PR 1598

* docs(changelog): correct pr number to 1598

* fix(jobs): preserve spool identity and report incomplete output honestly

* fix(jobs): retain bounded completed logs with cross-process ownership

* fix(jobs): finish integrating retention and task log diagnostics

* fix(jobs): preserve registry identity across workspace changes

* docs(jobs): explain unsafe log storage refusal

* fix(jobs): preserve safe startup expiry for completed log payloads

* fix: exclude runtime output from recursive search and bound log reads

* docs: consolidate bounded runtime logs change entry

* docs: use plain language for retained log ownership

* docs: make completed log retention separately searchable

* fix: preserve grep matches when bounded context skips long lines

* docs: associate bounded logs change with PR 1603

* fix: keep runtime search guidance within prompt budgets

* test: allow one explicit live verification model across roles

* test: allow one explicit live verification model across roles

* test: pin every terminal model role and expose default launch

* fix: resolve project ground on the default run door

* fix: tell every plan worker its assigned working directory

* fix: bound foreground spills and preserve selected folder aliases

* fix(teams): inherit approvals through the session before starting work

* docs: align standing explanations with engine-owned card wording

* Unify compact chat activity and preserve explicit user updates

* fix(session): keep daily guards current across conversations and midnight

* Cover explicit interim updates, fragmented markers and steering

* docs: use the supported changelog category

* docs: align change entry filename with pull request number

* docs: align change entry filename with pull request number

* Stream explicitly addressed updates immediately across chat views

* fix: exclude prompt history and pin every live text role

* docs: align foreground change entry with pull request number

* Verify task receipts remain available behind disclosure

* Keep resumed work in one activity window without stray receipts

* fix(tui3): anchor workspace selections through the workspace action

* test: wait for run teardown and isolate heartbeat phase checks

* Fold asynchronous task housekeeping while preserving requested command results

* test: wait for run teardown and isolate heartbeat phase checks

* fix(tui3): label workspace picker actions accurately

* Reset interim-update probes before textless new responses

* Record live terminal acceptance evidence for PR 1607

* test: observe delivered child news after conversation wake

* Preserve user-directed notices and close transcript transition gaps

* Recognize terminal rail gutter in live answer assertions

* Keep harness progress and interrupted work inside shared disclosures

* Publish verified final chat cleanup terminal captures

* fix(chat): defer independent pool judges in one-model runs

* Close interrupted response state when steering is consumed

* docs: record single-model pool judge policy for PR 1610

* test: preserve machine gate settings when pinning run models

* Account for interleaved captions in Codex redaction acceptance

* docs: record PR 1615 test fixture correction

* test: preserve machine gate settings when pinning run models

* Fold task reply provenance into shared work disclosure

* fix(session): join routing cache beat during close

* docs: record PR 1616 shutdown join

* Record deterministic caption acceptance fix

* fix: recover and cancel tasks with durable admission state

Addresses the restart and stopped-state portions of #1554, held task cancellation in #1571, and live machine limits in #1579. The separate read-helper fallback item in #1554 is outside this change.

* test: wait for program run owner before fixture cleanup

* docs: identify focused task recovery PR 1619

* test(session): join closed program run before fixture cleanup

* test(session): await run completion after its store closes

* fix(standing): preserve shared timer ownership during implicit setup

* test(session): await task receipts before asserting claim wait

* docs: describe durable audience and interrupted human updates

* docs: record shared timer ownership correction

* test: preserve machine gate settings when pinning run models

* test(session): await task receipts before asserting claim wait

* test(session): join closed program run before fixture cleanup

* test(session): await run completion after its store closes

* test(session): synchronize young bash steering without timing window

Fixes #1623.

* Preserve assistant audience and interruption across transcript replay

* fix(standing): explain unavailable background checks in approval receipt

* test(session): observe readings in the handover fixture

* test(session): hold the decision turn until resolution

* test(session): observe readings in the handover fixture

* test(session): hold the decision turn until resolution

* test(session): synchronize young bash steering without timing window

Fixes #1623.

* Keep interrupted human updates visible across shared chat views

Preserve explicit audience without confirming partial responses, retain full operational disclosure on replay, and exercise stop/steer/retry transitions across all lenses. Refs #1620.

* fix: account for paid responses discarded by reasoning retries

* docs: identify retry accounting PR 1625

* docs: retain Escape search terms for interrupted updates

* docs(cli): complete task and chat budget help synopses

* test: preserve machine gate settings when pinning run models

* docs: record CLI help correction in PR 1626

* fix(tui3): give task rooms the keyboard when opened

* docs: scope task note guidance to rooms accepting input

* docs(cli): fit complete help within existing page limits

* test: distinguish interrupted and completed steering collapse

* docs: identify task-room keyboard fix as PR 1628

* test(config): isolate credit fixtures from provider credentials

(cherry picked from commit 0c757ba6365a2d3d6b61ae7df4b4ba8b4679342f)

* test: reuse reviewed run teardown fixtures for clean validation

Reuse the existing #1619 orphan-run cleanup and #1622 owner-completion helper already integrated into Santosh/dev. No application code changes; avoids duplicating or masking the known temporary-directory race.

* docs: publish sustained chat UX acceptance and validation evidence

* test(chat): join first-run judge fixture usage writer

* docs: keep review recordings and generated evidence out of source

* test(provider): order hedge fixtures before visible primary progress

* session: a job's status is final before the log-folder sweep, not after it

Since #1603 every job's ending ran a whole retention sweep of its log folder
before its state left running, so StopWork's job read as running for 47-130 ms
under load (2 ms on dev), and TestStopWorkDoesNotWakeAndOnlyFreshSubmissionRestarts
failed 5 of 20 runs. settle now closes the file, publishes the final state,
runs the sweep, then closes done, so every waiter on done still joins the sweep.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* manual: the countdown's first quarter-second, and codeaf spelled lowercase

The proposal card drops a key pressed in its first quarter-second but moves
the pointer to `2 no` (#1594), so an enter straight after it declines; the
page now says so. The timer-ownership paragraph said "CodeAF says" in prose.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* Revert "session: a job's status is final before the log-folder sweep, not after it"

This reverts commit 8b0edfd. Publishing the final status before the sweep let
anything that watches running() tear a job's folder down while the sweep was
still writing in it: CI failed TestAParkedWorkerIsHandedBackWithARecordBeforeItsWholeAllowance
on 'TempDir RemoveAll cleanup: .codeaf/jobs: directory not empty'. The stop
latency it addressed comes back to be fixed on dev without that race.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* run: the placeholder-check test passes #1627's standing argument to NewBashWorker

#1634 landed on dev with a call written against the three-argument constructor;
#1627 gives plan-born workers the project's standing orders through a fourth.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: agentfield-bot <agentfield-bot@users.noreply.github.com>
Co-authored-by: CodeAF <267109073+agentfield-bot@users.noreply.github.com>
Co-authored-by: Abir Abbas <abirabbas1998@gmail.com>
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:chat The v3 surface a person sits in front of (internal/tui3) bug Something the code does that it should not sev:papercut A wording, a hint, a small wrongness that costs a moment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants