You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Correct the Home manual: a waiting standing-order row does not show when it is next due. It now directs readers to open the standing place for the due time. Add retrieval and CLI regressions for the question that exposed the incorrect answer.
How it was checked
go build ./... — passed (Go 1.26.5).
go test ./internal/manual -count=1 — passed.
go vet ./internal/manual — passed.
go run ./cmd/codeaf manual "when does a standing order go off on home" — returned the corrected Home guidance.
The tagged e2e package cross-compiled for Linux. It could not be executed on this Windows host; the existing e2e harness uses Unix-only syscalls. Full go vet ./... likewise encounters unrelated Windows-only build/test issues.
Thanks for the reminder. I have signed a CLA previously, but this PR's CLA Assistant check still shows not_signed. Could you confirm whether there is a project-specific CLA step or account association I need to complete if the PR-specific recheck does not update the status? I won't treat the CLA as complete until the check recognizes it.
Thanks for flagging this. We found that CodeAF wasn’t configured to share CLA signatures with our other repositories, and we’ve now enabled that. Your PR still shows the CLA as pending, though.
Could you open CodeAF’s CLA page while signed into GitHub as hy3560 and complete any signing prompt? Older repository-specific signatures may require signing once more. If it says you’ve already signed, please let us know which repository you originally signed for so we can investigate further.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Correct the Home manual: a waiting standing-order row does not show when it is next due. It now directs readers to open the standing place for the due time. Add retrieval and CLI regressions for the question that exposed the incorrect answer.
How it was checked
go build ./...— passed (Go 1.26.5).go test ./internal/manual -count=1— passed.go vet ./internal/manual— passed.go run ./cmd/codeaf manual "when does a standing order go off on home"— returned the corrected Home guidance.go vet ./...likewise encounters unrelated Windows-only build/test issues.Closes #1469.