fix(standing): normalize scope exclusions and resolve current budget quotes in the engine - #1596
Draft
santoshkumarradha wants to merge 4 commits into
Draft
santoshkumarradha wants to merge 4 commits into
santoshkumarradha wants to merge 4 commits into
Conversation
…e words, and task activity labels (#1555)
Member
Author
Two-Pass Quality ReviewPass 1: Defects & Contracts
Pass 2: Architecture & Clean Code
— |
santoshkumarradha
marked this pull request as ready for review
September 27, 2026 03:49
Member
Author
Pass 1 Review: Defects & Contracts
Drafted with CodeAF · reviewed and owned by the author |
Member
Author
Pass 2 Review: Architecture & Clean Code
Drafted with CodeAF · reviewed and owned by the author |
Member
Author
|
@AbirAbbas this is review ready |
santoshkumarradha
marked this pull request as draft
September 27, 2026 14:35
santoshkumarradha
marked this pull request as ready for review
September 27, 2026 15:18
This was referenced Sep 27, 2026
santoshkumarradha
marked this pull request as draft
September 27, 2026 16:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supplemental correction verified in separate PR #1612
The earlier Only now failure recorded below is corrected by separate PR #1612. Choosing Only now ran the actual pantry CLI and wrote SHOPPING.md without a corrective prompt, with no recurring schedule saved.
Tested revision
f855f2e6510c155b282cba388db2f92d2121dda3on Spark: a practical shopping-note workflow, 19 generated-project tests, unchanged inventory and zero saved recurring definitions. All 30 receipts used OpenRouterdeepseek/deepseek-v4.1-flash; Model Pool was disabled as disclosed in coverage/limitations.Fix PR #1612 · Video · GIF · Original terminal recording · Actual corrected card · Post-approval execution evidence
This evidence tests the separate corrective revision; it does not claim this PR’s original head already contains that fix. Earlier recordings and their limitations remain below. Tomorrow’s task was declined, not executed; ordinary model-action and permission limits still apply. Integration boundary: this #1612 base does not contain #1560 does.isolate, so ordinary Once tools do not prove isolated execution. Consolidation must suppress Once for isolated tasks or use a shared isolated executor. Isolated Once and watch/probe Once were not live-verified.
Real product workflow — recorded on Spark
Goal: Prepare a practical pantry plan, save a project-scoped permission rule and choose a weekly review with an accurate daily-budget quote.
Observed outcome: The app created and refreshed the plan without modifying inventory. The same open conversation quoted a $5 daily rail, then $7 after /budget day 7. Final stored standing rules were project scoped. However, choosing Only now falsely claimed completion without running the task; an explicit user correction was needed to refresh the report.
Watch the workflow (MP4) · Animated GIF · Original terminal recording (.cast)
Evidence: tested revision
a955db54ed5e4dc26287aec18c1fd6bc3ef31be7; Spark sessioncritical-extended-1596-v2. Execution/binary identity, model receipts, checksums and playback details. All 50 recorded calls used OpenRouterdeepseek/deepseek-v4.1-flash, including auxiliary calls. Final saved standing states.Playback and limits: Original
.castis preserved; GIF/MP4 play at 3× speed with idle intervals capped at 3 seconds. PARTIAL ACCEPTANCE: issue #1611 blocks the Only now path; this recording is evidence of the defect and recovery, not a passing once-execution test. The separately recorded correction in PR #1612 is linked above; it is not part of this original tested revision. Run used --one-model with Model Pool disabled for issue #1608; initial failed-policy evidence is retained separately.Standing orders compare project reach and project exclusions using the same normalized path identity. Empty paths cannot become the current directory. Task firings are labelled
task:instead ofsaid:.The engine reads the current daily allowance when creating a proposal. Explicit per-run cost wording stays intact. The renderer quotes the proposal snapshot without inspecting text to infer policy or reading settings on every frame.
Resolves #1555.
Validation:
deepseek/deepseek-v4.1-flash, including auxiliary roles.