fix(teams): manager conversation initialization and approval posture inheritance (#1551)

[santoshkumarradha]

Summary

Fixes issue #1551:

1. Derives fallback handles for untitled manager conversations to allow correct team_send routing.
2. Propagates approval posture from parent manager to sub-teams spawned via team_start.
3. Fixes consent card wording to display full lifecycle description instead of literal internal keywords.

Changes

• Updated manager session setup in internal/session and internal/session/team_start.go.
• Added unit and regression tests covering manager handles and sub-team posture inheritance.

Fixes #1551

---

Drafted with CodeAF · reviewed and owned by the author

[santoshkumarradha]

Pass 1 Review: Defects & Contracts

• Defects check:
  • Issue 1: Untitled manager conversation had empty handle, preventing team_send routing. Fixed via FallbackHandle in internal/teams/handle.go and applied in teamMakeManager, teamsRootManagerStart, and assignHandles.
  • Issue 2: Sub-team manager started via team_start did not inherit approval posture. Fixed by propagating Approval: a.ResolvedApprovalPosture() in teamstore.Entry in team_nest.go and tools_team.go, and applying it in trafficStarted to both agent runtime and meta.json.
  • Issue 3: Consent card displayed literal keyword "default" instead of lifecycle explanation. Fixed in internal/session/consent.go consentRule to return teamStartCost for unset/default rules.
• Contract check:
  • Validates ValidHandle on all generated fallback handles.
  • Child manager session receives inherited approval posture in both live agent runtime and persistent meta.json.
• Verdict: PASS 1 Clean.

_{drafted with CodeAF}

[santoshkumarradha]

Pass 2 Review: Architecture & Software Craft

• Architecture check:
  • Follows established patterns for team store transactions (f.SetManager, f.SetHandle) and Bubble Tea async command chains.
  • Proper fallback derivation logic avoiding collision with existing team member handles.
• Hygiene & Tests:
  • Added tests: TestFallbackHandle in handle_test.go, TestTheStartsCardSaysWhoIsStartedAndWhatItCosts in teamevent_test.go, TestTrafficStartInheritsApprovalPosture, and TestUntitledManagerGetsFallbackHandle in teamtraffic_test.go.
• Verdict: PASS 2 Clean.

_{drafted with CodeAF}

[santoshkumarradha]

Pass 3 Review: Production Readiness & Verification

• Production readiness:
  • Regression tested: Manager conversation auto-initialization, handle fallback to base transcript ID, and child thread approval posture inheritance all function cleanly.
  • No unexpected side-effects on existing standalone agent setups or team traffic routing.
• Verification:
  • Full test suite passed across all cross-compilation platforms and shards.
  • Unit and integration tests in internal/session/team_test.go and internal/session/team_wakewatch.go pass.
• Verdict: PASS 3 Approved for production merge.

_{drafted with CodeAF}

[santoshkumarradha]

@AbirAbbas this is review ready