Repository navigation
feat(web): restyle console with shadcn-admin layout - #14
Conversation
Rebuild the frontend on Tailwind v4 and shadcn tokens: fixed collapsible sidebar, sticky blurred header, card/badge/table primitives, and light/dark themes. Preserve API contracts, integer-cent money formatting, server-side roles and all test-facing labels. Keep wide tables inside their own scroll areas, and keep approval actions bound to the opened recommendation while the list refreshes. Co-Authored-By: Claude Code <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 47a98c972e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| 'fixed inset-y-0 left-0 z-50 flex w-64 flex-col border-r bg-sidebar text-sidebar-foreground transition-[width,transform] duration-200 ease-in-out md:z-30 md:translate-x-0', | ||
| mobileOpen ? 'translate-x-0' : '-translate-x-full', | ||
| collapsed ? 'md:w-14' : 'md:w-64', |
There was a problem hiding this comment.
Remove the closed mobile sidebar from keyboard navigation
Below the md breakpoint, closing the sidebar only translates it offscreen; its six navigation buttons remain focusable and exposed to assistive technology. Consequently, tabbing from the start of the page, or continuing after selecting a navigation item closes the drawer, moves focus through invisible controls rather than the visible workspace. Hide or make the closed mobile sidebar inert, while preserving desktop navigation, and restore focus to the menu trigger when closing it.
Useful? React with 👍 / 👎.
变更摘要
前端按
satnaing/shadcn-admin的布局与视觉风格重构:Tailwind CSS v4 + shadcn 设计令牌、可折叠固定侧边栏、粘性顶栏、Card / Badge / Table 等基础组件、浅色与深色主题。保留既有 API 契约、USD 整数美分格式化、服务端角色校验与全部测试依赖的可访问名称。同时修复两处 e2e 暴露的问题:
md:及以上启用过渡)。selectedId时才回退到首条。关联任务
无
实际验证
python -m pytest backend/tests -q— 未验证(本次仅前端改动,未执行)npm --prefix frontend testnpm --prefix frontend run buildnpm --prefix frontend run test:e2e(Playwright,7 个用例)python scripts/mcp_check.py— 未验证(本次仅前端改动,未执行)python scripts/smoke.py— 未验证(本次仅前端改动,未执行)docker compose config --quiet— 未验证(未涉及 Compose)验证结果:
docs/screenshots/已由 e2e 重新生成(overview / approval / execution / mobile / agent-trace / agent-trace-mobile)。安全与边界
.env、API Key、数据库、缓存、构建产物或本机运行数据契约与文档
docs/EVALUATION.md未涉及)审查提示
请重点检查金额守恒、证据 ID 可追溯性、LLM 失败/降级可见性、审批执行幂等和敏感信息。自动审查工具的评论只是辅助,不替代人工审查。
🤖 Generated with Claude Code