Repository navigation
Move schemaChanged, returnTrue, n2u, und and getXLSX from alasql.private to internal - #2837
Merged
Merged
Conversation
…ate to internal; they never shipped
mathiasrw
changed the base branch from
fix/step4-prototype-internal
to
feature/rollup
October 21, 2026 16:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2836. The five names the conversion had put on
alasql.privatebefore the mechanism was decided move tointernal, the second install parameter:schemaChanged(core.js),returnTrue,n2u,und(helpers.js) andgetXLSX(xlsx.js). They never shipped, so they never become public.alasql.private.externalXlsxLibstays: it is in 4.21.0.internal.test/parity/api-allowed.txtloses the five entries; what remains is the.nameof the exported helpers.tools/wrap.jsno longer has--private; internals go oninternalor nowhere.Checks on the tip: suite 2447 pass, parity 0 differences over 76,999 statements with the API identical apart from the helper names, smokes green.
Base is
fix/step4-prototype-internal; GitHub retargets this tofeature/rollupwhen that branch is deleted after its merge.