Skip to content

TPC SCD: add option to keep all cluster and add MC to unbinned residuals #15893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matthias-kleiner wants to merge 6 commits into
base: dev
Choose a base branch
from
+582 −111
Open

TPC SCD: add option to keep all cluster and add MC to unbinned residuals #15893

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8ae4f15
TPC SCD: add keepClustersOnPropFail to keep tracks whose reference pr…
matthias-kleiner Sep 25, 2026
2ce8a00
TPC SCD: store the MC truth of the residual tracks (--enable-mc)
matthias-kleiner Oct 3, 2026
e869868
TPC SCD: MC truth at the TRD (entrance and ideal tracklet positions)
matthias-kleiner Oct 3, 2026
d745182
TPC SCD: MC origin of the residual tracks (mother, production vertex,…
matthias-kleiner Oct 3, 2026
333cdd5
MCKinematicsReader: keep the loaded tracks instead of copying them, f…
matthias-kleiner Oct 3, 2026
13be6aa
MCKinematicsReader: load and release the track references per event
matthias-kleiner Oct 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ...Workflow/tpcinterpolationworkflow/include/TPCInterpolationWorkflow/TPCInterpolationSpec.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,14 @@
#include "DetectorsBase/GRPGeomHelper.h"
#include "TPCCalibration/VDriftHelper.h"
#include "DataFormatsITSMFT/TopologyDictionary.h"
#include "Steer/MCKinematicsReader.h"

using namespace o2::framework;

namespace o2::globaltracking
{
struct DataRequest;
struct RecoContainer;
} // namespace o2::globaltracking

namespace o2
Expand All @@ -40,14 +42,15 @@ class TPCInterpolationDPL : public Task
public:
TPCInterpolationDPL(std::shared_ptr<o2::globaltracking::DataRequest> dr, o2::dataformats::GlobalTrackID::mask_t src, o2::dataformats::GlobalTrackID::mask_t srcMap, std::shared_ptr<o2::base::GRPGeomRequest> gr, bool useMC,
bool processITSTPConly, bool sendTrackData, bool debugOutput, bool extDetResid) : mDataRequest(dr), mSources(src), mSourcesMap(srcMap), mGGCCDBRequest(gr), mUseMC(useMC), mProcessITSTPConly(processITSTPConly), mSendTrackData(sendTrackData), mDebugOutput(debugOutput), mExtDetResid(extDetResid) {}
~TPCInterpolationDPL() override = default;
~TPCInterpolationDPL() override;
void init(InitContext& ic) final;
void run(ProcessingContext& pc) final;
void endOfStream(EndOfStreamContext& ec) final;
void finaliseCCDB(ConcreteDataMatcher& matcher, void* obj) final;

private:
void updateTimeDependentParams(ProcessingContext& pc);
void fillMCTruth(const o2::globaltracking::RecoContainer& recoData);
o2::tpc::TrackInterpolation mInterpolation; ///< track interpolation engine
std::shared_ptr<o2::globaltracking::DataRequest> mDataRequest; ///< steers the input
std::shared_ptr<o2::base::GRPGeomRequest> mGGCCDBRequest;
Expand All @@ -56,6 +59,8 @@ class TPCInterpolationDPL : public Task
o2::dataformats::GlobalTrackID::mask_t mSources{}; ///< which input sources are configured
o2::dataformats::GlobalTrackID::mask_t mSourcesMap{}; ///< possible subset of mSources specifically for map creation
bool mUseMC{false}; ///< MC flag
std::unique_ptr<o2::steer::MCKinematicsReader> mMCReader; ///< MC kinematics and track references (MC only)
std::vector<TrackDataMC> mTrackDataMC; ///< MC truth aligned with the TrackData output (MC only)
bool mProcessITSTPConly{false}; ///< should also tracks without outer point (ITS-TPC only) be processed?
bool mProcessSeeds{false}; ///< process not only most complete track, but also its shorter parts
bool mDebugOutput{false}; ///< add more information to the output (track points of ITS, TRD and TOF)
Expand Down
21 changes: 17 additions & 4 deletions ...low/tpcinterpolationworkflow/include/TPCInterpolationWorkflow/TPCResidualAggregatorSpec.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ namespace calibration
class ResidualAggregatorDevice : public o2::framework::Task
{
public:
ResidualAggregatorDevice(std::shared_ptr<o2::base::GRPGeomRequest> req, bool trackInput, bool ctpInput, bool writeUnbinnedResiduals, bool writeBinnedResiduals, bool writeTrackData, std::shared_ptr<o2::globaltracking::DataRequest> dataRequest) : mCCDBRequest(req), mTrackInput(trackInput), mCTPInput(ctpInput), mWriteUnbinnedResiduals(writeUnbinnedResiduals), mWriteBinnedResiduals(writeBinnedResiduals), mWriteTrackData(writeTrackData), mDataRequest(dataRequest) {}
ResidualAggregatorDevice(std::shared_ptr<o2::base::GRPGeomRequest> req, bool trackInput, bool ctpInput, bool writeUnbinnedResiduals, bool writeBinnedResiduals, bool writeTrackData, bool mcInput, std::shared_ptr<o2::globaltracking::DataRequest> dataRequest) : mCCDBRequest(req), mTrackInput(trackInput), mCTPInput(ctpInput), mWriteUnbinnedResiduals(writeUnbinnedResiduals), mWriteBinnedResiduals(writeBinnedResiduals), mWriteTrackData(writeTrackData), mMCInput(mcInput), mDataRequest(dataRequest) {}

void init(o2::framework::InitContext& ic) final
{
Expand Down Expand Up @@ -97,6 +97,7 @@ class ResidualAggregatorDevice : public o2::framework::Task
mAggregator->setWriteBinnedResiduals(mWriteBinnedResiduals);
mAggregator->setWriteUnbinnedResiduals(mWriteUnbinnedResiduals);
mAggregator->setWriteTrackData(mWriteTrackData);
mAggregator->setWriteTrackDataMC(mMCInput);
mAggregator->setCompression(ic.options().get<int>("compression"));
}

Expand Down Expand Up @@ -141,6 +142,14 @@ class ResidualAggregatorDevice : public o2::framework::Task
trkData.emplace(pc.inputs().get<gsl::span<o2::tpc::TrackData>>("trkData"));
trkDataPtr = &trkData.value();
}
// MC truth of the track data (optional, MC only)
const gsl::span<const o2::tpc::TrackDataMC>* trkDataMCPtr = nullptr;
using trkDataMCType = std::decay_t<decltype(pc.inputs().get<gsl::span<o2::tpc::TrackDataMC>>(""))>;
std::optional<trkDataMCType> trkDataMC;
if (mMCInput) {
trkDataMC.emplace(pc.inputs().get<gsl::span<o2::tpc::TrackDataMC>>("trkDataMC"));
trkDataMCPtr = &trkDataMC.value();
}
// CTP lumi input (optional)
const o2::ctp::LumiInfo* lumi = nullptr;
using lumiDataType = std::decay_t<decltype(pc.inputs().get<o2::ctp::LumiInfo>(""))>;
Expand All @@ -152,7 +161,7 @@ class ResidualAggregatorDevice : public o2::framework::Task

o2::base::TFIDInfoHelper::fillTFIDInfo(pc, mAggregator->getCurrentTFInfo());
LOG(detail) << "Processing TF " << mAggregator->getCurrentTFInfo().tfCounter << " with " << trkData->size() << " tracks and " << residualsData.size() << " unbinned residuals associated to them";
mAggregator->process(residualsData, residualsDataDet, trackRefs, trkDataPtr, lumi);
mAggregator->process(residualsData, residualsDataDet, trackRefs, trkDataPtr, trkDataMCPtr, lumi);
std::chrono::duration<double, std::milli> runDuration = std::chrono::high_resolution_clock::now() - runStartTime;
LOGP(debug, "Duration for run method: {} ms. From this taken for time dependent param update: {} ms",
std::chrono::duration_cast<std::chrono::milliseconds>(runDuration).count(),
Expand Down Expand Up @@ -205,6 +214,7 @@ class ResidualAggregatorDevice : public o2::framework::Task
bool mWriteBinnedResiduals{false}; ///< flag, whether to write binned residuals to output file
bool mWriteUnbinnedResiduals{false}; ///< flag, whether to write unbinned residuals to output file
bool mWriteTrackData{false}; ///< flag, whether to write track data to output file
bool mMCInput{false}; ///< flag whether to expect the MC truth of the track data as input
bool mRunStopRequested{false}; ///< flag in case the run was stopped
bool mInitDone{false}; ///< flag whether initialization was done for current run
};
Expand All @@ -214,7 +224,7 @@ class ResidualAggregatorDevice : public o2::framework::Task
namespace framework
{

DataProcessorSpec getTPCResidualAggregatorSpec(bool trackInput, bool ctpInput, bool writeUnbinnedResiduals, bool writeBinnedResiduals, bool writeTrackData)
DataProcessorSpec getTPCResidualAggregatorSpec(bool trackInput, bool ctpInput, bool writeUnbinnedResiduals, bool writeBinnedResiduals, bool writeTrackData, bool mcInput = false)
{
std::shared_ptr<o2::globaltracking::DataRequest> dataRequest = std::make_shared<o2::globaltracking::DataRequest>();
if (ctpInput) {
Expand All @@ -227,6 +237,9 @@ DataProcessorSpec getTPCResidualAggregatorSpec(bool trackInput, bool ctpInput, b
inputs.emplace_back("trackRefs", "GLO", "TRKREFS");
if (trackInput) {
inputs.emplace_back("trkData", "GLO", "TRKDATA");
if (mcInput) {
inputs.emplace_back("trkDataMC", "GLO", "TRKDATAMC");
}
}
auto ccdbRequest = std::make_shared<o2::base::GRPGeomRequest>(true, // orbitResetTime
true, // GRPECS=true
Expand All @@ -240,7 +253,7 @@ DataProcessorSpec getTPCResidualAggregatorSpec(bool trackInput, bool ctpInput, b
"residual-aggregator",
inputs,
Outputs{},
AlgorithmSpec{adaptFromTask<o2::calibration::ResidualAggregatorDevice>(ccdbRequest, trackInput, ctpInput, writeUnbinnedResiduals, writeBinnedResiduals, writeTrackData, dataRequest)},
AlgorithmSpec{adaptFromTask<o2::calibration::ResidualAggregatorDevice>(ccdbRequest, trackInput, ctpInput, writeUnbinnedResiduals, writeBinnedResiduals, writeTrackData, trackInput && mcInput, dataRequest)},
Options{
{"sec-per-slot", VariantType::UInt32, 600u, {"number of seconds per calibration time slot (put 0 for infinite slot length)"}},
{"updateInterval", VariantType::UInt32, 6'000u, {"update interval in number of TFs (only used in case slot length is infinite)"}},
Expand Down
Loading
Loading