Skip to content

[PWGLF] Add derivedXi0analysis task - #18081

Merged
romainschotter merged 15 commits into
AliceO2Group:masterfrom
romainschotter:xi0
Sep 29, 2026
Merged

[PWGLF] Add derivedXi0analysis task#18081
romainschotter merged 15 commits into
AliceO2Group:masterfrom
romainschotter:xi0

Conversation

@romainschotter

@romainschotter romainschotter commented Sep 28, 2026

Copy link
Copy Markdown
Collaborator
  • fix mistakes sigma0builder
  • fix mistakes in Xi0 data model
  • add derivedXi0 analysis

@github-actions github-actions Bot changed the title Add derivedXi0analysis task [PWGLF] Add derivedXi0analysis task Sep 28, 2026
@github-actions

github-actions Bot commented Sep 28, 2026 •
edited
Loading

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 528 warnings, 🔕 1 disabled

@alibuild alibuild mentioned this pull request Sep 28, 2026
Merged
@alibuild alibuild mentioned this pull request Sep 28, 2026
Merged
@romainschotter
romainschotter marked this pull request as ready for review September 28, 2026 22:29
@romainschotter
romainschotter enabled auto-merge (squash) September 28, 2026 22:30
alibuild
alibuild previously approved these changes Sep 28, 2026
View reviewed changes

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @romainschotter.

@alibuild

alibuild commented Sep 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for e65ac69 at 2026-09-29 04:45:

## sw/BUILD/O2Physics-latest/log
CMake Error at cmake/O2PhysicsAddExecutable.cmake:113 (add_executable):
CMake Error at cmake/O2PhysicsAddExecutable.cmake:113 (add_executable):

Full log here.

@alibuild

alibuild commented Sep 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for e65ac69 at 2026-09-29 02:43:

## sw/BUILD/O2Physics-latest/log
CMake Error at cmake/O2PhysicsAddExecutable.cmake:113 (add_executable):
CMake Error at cmake/O2PhysicsAddExecutable.cmake:113 (add_executable):

Full log here.

@alibuild

alibuild commented Sep 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for e65ac69 at 2026-09-29 03:02:

## sw/BUILD/O2Physics-latest/log
CMake Error at cmake/O2PhysicsAddExecutable.cmake:113 (add_executable):
CMake Error at cmake/O2PhysicsAddExecutable.cmake:113 (add_executable):

Full log here.

@alibuild

alibuild commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for a616bea at 2026-09-29 08:23:

## sw/BUILD/O2Physics-latest/log
CMake Error at cmake/O2PhysicsAddExecutable.cmake:113 (add_executable):
CMake Error at cmake/O2PhysicsAddExecutable.cmake:113 (add_executable):

Full log here.

@romainschotter
romainschotter enabled auto-merge (squash) September 29, 2026 06:52
alibuild
alibuild approved these changes Sep 29, 2026
View reviewed changes

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @romainschotter.

@romainschotter
romainschotter merged commit 4c87d0e into AliceO2Group:master Sep 29, 2026
13 of 15 checks passed
@alibuild

alibuild commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 10d1e18 at 2026-09-29 12:46:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 3 errors and 260 warnings.'
Found 3 errors and 260 warnings.
++ [[ 3 -gt 0 ]]
++ cat /sw/BUILD/c33da290235b646654ad68b3b3298a2c3c9b82d2/O2Physics-code-check/errors.txt
PWGLF/Tasks/Strangeness/derivedXi0analysis.cxx:53:1: error: included header MathConstants.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/derivedXi0analysis.cxx:67:1: error: included header TH2.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/derivedXi0analysis.cxx:68:1: error: included header TPDGCode.h is not used directly [misc-include-cleaner,-warnings-as-errors]
++ [[ 260 -gt 0 ]]
++ cat /sw/BUILD/c33da290235b646654ad68b3b3298a2c3c9b82d2/O2Physics-code-check/warnings.txt
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:80:8: warning: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:413:9: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:414:11: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:415:11: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:416:11: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:417:11: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:418:11: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:419:11: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:420:11: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:516:64: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1104:226: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1108:274: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1255:68: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1257:69: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1259:69: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1263:91: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1265:92: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1267:92: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1351:26: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1357:47: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1362:33: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1540:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1545:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1550:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1555:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1560:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1565:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1570:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1575:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1580:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1585:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1590:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1595:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1600:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1605:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1610:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1615:19: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

@romainschotter
romainschotter deleted the xi0 branch September 29, 2026 11:56
vkucera
vkucera reviewed Oct 6, 2026
View reviewed changes
Comment thread PWGLF/Tasks/Strangeness/derivedXi0analysis.cxx
Comment on lines +683 to +687
if (fillHists)
histos.fill(HIST("hEventSelection"), 21 /* Above max IR */);

if (fillHists) {
histos.fill(HIST("hEventSelection"), 22 /* selected collisions */);

@vkucera vkucera Oct 6, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cppcheck correctly complains that there are two identical consecutive conditions and nothing in between which seems like the selection step 21 is missing. Can you please check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkucera vkucera vkucera left review comments
@alibuild alibuild alibuild approved these changes
@omvazque omvazque Awaiting requested review from omvazque omvazque is a code owner
@mpuccio mpuccio Awaiting requested review from mpuccio mpuccio is a code owner
@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner
@ercolessi ercolessi Awaiting requested review from ercolessi ercolessi is a code owner
@lhusova lhusova Awaiting requested review from lhusova lhusova is a code owner
@gbencedi gbencedi Awaiting requested review from gbencedi gbencedi is a code owner
@abmodak abmodak Awaiting requested review from abmodak abmodak is a code owner
@mario-krueger mario-krueger Awaiting requested review from mario-krueger mario-krueger is a code owner
@maciacco maciacco Awaiting requested review from maciacco maciacco is a code owner
@HorstMa HorstMa Awaiting requested review from HorstMa HorstMa is a code owner
@dmallick2 dmallick2 Awaiting requested review from dmallick2 dmallick2 is a code owner
@smaff92 smaff92 Awaiting requested review from smaff92 smaff92 is a code owner
@prottayCMT prottayCMT Awaiting requested review from prottayCMT prottayCMT is a code owner

Assignees

No one assigned

Labels

datamodel pwglf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@romainschotter @alibuild @vkucera