Conversation
Needed to account for BC mask in analysis for cross section calculation in light ions
Added CCDB manager and GRPLHCIFData handling to processZDCBC method. Introduced new bitset patterns for beam and bunch configurations. Needed for cross-section calculation in light ions
Needed for cross-section calculation in small systems
coppedis
requested review from
a team,
alibuild,
ddobrigk,
dsekihat,
iarsene,
jgrosseo and
ktf
as code owners
October 1, 2026 06:28
github-actions
Bot
changed the title
|
O2 linter results: ❌ 0 errors, |
to overcome megalinter issues
Collaborator
|
Error while checking build/O2Physics/code-check for c0ad95b at 2026-10-01 09:09: Full log here. |
vkucera
requested changes
Oct 1, 2026
Comment on lines
-20
to
+26
| #include <Framework/Configurable.h> | ||
| #include <Framework/HistogramRegistry.h> | ||
| #include <Framework/HistogramSpec.h> | ||
| #include <Framework/InitContext.h> | ||
| #include <Framework/OutputObjHeader.h> | ||
| #include <Framework/runDataProcessing.h> | ||
|
|
||
| #include <TH1.h> | ||
| #include <TH2.h> | ||
| #include <TH1F.h> | ||
| #include <TH2F.h> | ||
|
|
||
| #include <cstdio> |
Collaborator
There was a problem hiding this comment.
Please do not revert fixes.
Contributor
Author
There was a problem hiding this comment.
don't fully get what you mean here, sorry...
Contributor
Author
There was a problem hiding this comment.
Dear @vkucera,
is there any change I am still missing here?
Collaborator
There was a problem hiding this comment.
Yes, you are still removing includes which should stay, as you can see from the changes in this PR and from the log of the code-check.
…oup#15380 Updated histogram includes to use TH1 and TH2 instead of TH1F and TH2F.
Collaborator
Collaborator
|
Error while checking build/O2Physics/code-check for 6835f98 at 2026-10-03 01:10: Full log here. |
Collaborator
|
Error while checking build/O2Physics/code-check for c867ae1 at 2026-10-05 20:19: Full log here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In data model a column to store the BC mask and select events has been added.
In the task, the handling of data has been redesigned to account for beam mask.
The analysis macro has also been updated.
All the changes are needed in order to analyse ZDC data to calculate the cross section in OO and Ne-Ne data taking.