Skip to content

[ALICE3] Refactor alice3 configuration parser - #18145

Merged
jesgum merged 1 commit into
AliceO2Group:masterfrom
jesgum:tenv-parser
Oct 2, 2026
Merged

jesgum merged 1 commit into
AliceO2Group:masterfrom
jesgum:tenv-parser

Conversation

@jesgum

@jesgum jesgum commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator

In order to use the TEnv parser in the Decayer without needing the entire GeometryContainer it's moved to its own class

@github-actions github-actions Bot added the alice3 label Oct 2, 2026
@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 12 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Refactor alice3 configuration parser [ALICE3] Refactor alice3 configuration parser Oct 2, 2026
@jesgum
jesgum marked this pull request as ready for review October 2, 2026 07:39
@alibuild

alibuild commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 203b86a at 2026-10-02 14:10:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 8 errors and 22 warnings.'
Found 8 errors and 22 warnings.
++ [[ 8 -gt 0 ]]
++ cat /sw/BUILD/7fd0ca22f5cbe02fe99834f7a58c08774394164f/O2Physics-code-check/errors.txt
ALICE3/Core/ConfigurationParser.cxx:98:14: error: constness of 'localPath' prevents automatic move [performance-no-automatic-move,-warnings-as-errors]
ALICE3/Core/ConfigurationParser.cxx:105:14: error: constness of 'localPath' prevents automatic move [performance-no-automatic-move,-warnings-as-errors]
ALICE3/Core/ConfigurationParser.cxx:125:18: error: constness of 'localPath' prevents automatic move [performance-no-automatic-move,-warnings-as-errors]
ALICE3/Core/ConfigurationParser.cxx:132:18: error: constness of 'localPath' prevents automatic move [performance-no-automatic-move,-warnings-as-errors]
ALICE3/Core/ConfigurationParser.cxx:141:14: error: constness of 'localPath' prevents automatic move [performance-no-automatic-move,-warnings-as-errors]
ALICE3/Core/ConfigurationParser.cxx:149:14: error: constness of 'localPath' prevents automatic move [performance-no-automatic-move,-warnings-as-errors]
ALICE3/Core/ConfigurationParser.cxx:206:12: error: constness of 'localPath' prevents automatic move [performance-no-automatic-move,-warnings-as-errors]
ALICE3/Core/GeometryContainer.cxx:22:1: error: included header BasicCCDBManager.h is not used directly [misc-include-cleaner,-warnings-as-errors]
++ [[ 22 -gt 0 ]]
++ cat /sw/BUILD/7fd0ca22f5cbe02fe99834f7a58c08774394164f/O2Physics-code-check/warnings.txt
ALICE3/Core/ConfigurationParser.cxx:72:15: warning: use starts_with instead of find [modernize-use-starts-ends-with]
ALICE3/Core/ConfigurationParser.cxx:84:12: warning: use starts_with instead of rfind [modernize-use-starts-ends-with]
ALICE3/Core/ConfigurationParser.cxx:95:5: warning: uninitialized record type: 'buffer' [cppcoreguidelines-pro-type-member-init]
ALICE3/Core/FlatTrackSmearer.cxx:174:25: warning: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast]
ALICE3/Core/GeometryContainer.cxx:44:8: warning: variable 'cleanLutWhenLoaded' is not initialized [cppcoreguidelines-init-variables]
ALICE3/Core/GeometryContainer.cxx:71:5: warning: do not use 'else' after 'return' [readability-else-after-return]
ALICE3/Core/GeometryContainer.cxx:93:5: warning: do not use 'else' after 'return' [readability-else-after-return]
ALICE3/Core/GeometryContainer.h:48:3: warning: function 'getConfigurations' should be marked [[nodiscard]] [modernize-use-nodiscard]
ALICE3/Core/GeometryContainer.h:49:3: warning: function 'getConfiguration' should be marked [[nodiscard]] [modernize-use-nodiscard]
ALICE3/Core/GeometryContainer.h:50:3: warning: function 'getLayerNames' should be marked [[nodiscard]] [modernize-use-nodiscard]
ALICE3/Core/GeometryContainer.h:51:3: warning: function 'hasValue' should be marked [[nodiscard]] [modernize-use-nodiscard]
ALICE3/Core/GeometryContainer.h:52:3: warning: function 'getValue' should be marked [[nodiscard]] [modernize-use-nodiscard]
ALICE3/Core/GeometryContainer.h:55:3: warning: function 'getFloatValue' should be marked [[nodiscard]] [modernize-use-nodiscard]
ALICE3/Core/GeometryContainer.h:56:3: warning: function 'getIntValue' should be marked [[nodiscard]] [modernize-use-nodiscard]
ALICE3/Core/GeometryContainer.h:81:3: warning: function 'getNumberOfConfigurations' should be marked [[nodiscard]] [modernize-use-nodiscard]
ALICE3/Core/GeometryContainer.h:82:3: warning: function 'getEntries' should be marked [[nodiscard]] [modernize-use-nodiscard]
ALICE3/Core/GeometryContainer.h:83:3: warning: function 'getEntry' should be marked [[nodiscard]] [modernize-use-nodiscard]
ALICE3/Core/GeometryContainer.h:84:3: warning: function 'getGeometryEntry' should be marked [[nodiscard]] [modernize-use-nodiscard]
ALICE3/Core/GeometryContainer.h:88:3: warning: function 'getConfigurations' should be marked [[nodiscard]] [modernize-use-nodiscard]
ALICE3/Core/GeometryContainer.h:89:3: warning: function 'getConfiguration' should be marked [[nodiscard]] [modernize-use-nodiscard]
ALICE3/Core/GeometryContainer.h:92:3: warning: function 'getValue' should be marked [[nodiscard]] [modernize-use-nodiscard]
ALICE3/Core/GeometryContainer.h:93:3: warning: function 'getFloatValue' should be marked [[nodiscard]] [modernize-use-nodiscard]
++ [[ 8 -gt 0 ]]
++ exit 1
--

Full log here.

@jesgum

jesgum commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator Author

Problems reported by the linters should be addressed separately

@jesgum
jesgum enabled auto-merge (squash) October 2, 2026 12:15

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @jesgum.

@jesgum
jesgum merged commit b4cc6ec into AliceO2Group:master Oct 2, 2026
13 of 15 checks passed
@jesgum
jesgum deleted the tenv-parser branch October 2, 2026 12:16
@vkucera

vkucera commented Oct 3, 2026

Copy link
Copy Markdown
Collaborator

Problems reported by the linters should be addressed separately

The errors were introduced by this PR. Can you please clarify why you did not fix them before merging?

@njacazio

njacazio commented Oct 3, 2026 •

Copy link
Copy Markdown
Collaborator

Hi Vit,
The merge was not forced against the CI; the configured check priority was respected, as recently restated by the analysis coordination
I agree with the decision to merge, since it was already known that the warnings would be addressed in a follow-up PR. This also avoids rerunning checks that have already passed.
Thanks for the comment and take care!

@vkucera

vkucera commented Oct 3, 2026

Copy link
Copy Markdown
Collaborator

Hi Vit, The merge was not forced against the CI; the configured check priority was respected, as recently restated by the analysis coordination I agree with the decision to merge, since it was already known that the warnings would be addressed in a follow-up PR. This also avoids rerunning checks that have already passed. Thanks for the comment and take care!

The point of CI is to prevent new errors from getting merged in the upstream. This cannot work if there are pre-existing errors merged in the past.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants