[PWGLF] Added and upgraded derived data processes and mc closure process - #18147
Merged
Merged
Conversation
nkaratze
requested review from
alibuild,
ercolessi,
lhusova,
mpuccio,
omvazque,
romainschotter and
skundu692
as code owners
October 2, 2026 09:37
|
O2 linter results: ❌ 0 errors, |
Collaborator
romainschotter
requested changes
Oct 2, 2026
| Configurable<bool> doNoSameBunchPileup{"doNoSameBunchPileup", true, "Enable NoSameBunchPileup event selection"}; | ||
| Configurable<bool> doIsVertexITSTPC{"doIsVertexITSTPC", true, "Enable IsVertexITSTPC event selection"}; | ||
| Configurable<bool> doisInelGt0{"doisInelGt0", true, "Enable isInelGt0 event selection"}; | ||
| struct EventSelectionConfig { |
Collaborator
There was a problem hiding this comment.
You should instead make it a configurable group instead of a simple struct
struct : ConfigurableGroup {
std::string prefix = "eventSelections"; // JSON group name
}
Please be aware that your configurables in Hyperloop will all be reset to their default value.
| Configurable<bool> doDaughterPseudorapidityCut{"doDaughterPseudorapidityCut", true, "Enable Daughter pseudorapidity v0 selection"}; | ||
| Configurable<bool> doisNotITSAfterburner{"doisNotITSAfterburner", true, "Enable Tracks do not come from Afterburner"}; | ||
| Configurable<bool> doitsMinHits{"doitsMinHits", true, "Enable ITS Minimum hits"}; | ||
| struct V0SelectionConfig { |
Collaborator
There was a problem hiding this comment.
Use configurable group as well
| Configurable<bool> doK0shv0radiusCut{"doK0shv0radiusCut", true, "Enable K0sh v0radius Topological Cut"}; | ||
| Configurable<bool> doK0shdcaposdautopv{"doK0shdcaposdautopv", true, "Enable K0sh DCA pos daughter to PV Topological Cut"}; | ||
| Configurable<bool> doK0shdcanegdautopv{"doK0shdcanegdautopv", true, "Enable K0sh DCA neg daughter to PV Topological Cut"}; | ||
| struct K0shSelectionConfig { |
Collaborator
There was a problem hiding this comment.
Use configurable group as well
| Configurable<bool> doLambdav0radiusCut{"doLambdav0radiusCut", true, "Enable Lambda v0radius Topological Cut"}; | ||
| Configurable<bool> doLambdadcaposdautopv{"doLambdadcaposdautopv", true, "Enable Lambda DCA pos daughter to PV Topological Cut"}; | ||
| Configurable<bool> doLambdadcanegdautopv{"doLambdadcanegdautopv", true, "Enable Lambda DCA neg daughter to PV Topological Cut"}; | ||
| struct LambdaSelectionConfig { |
Collaborator
There was a problem hiding this comment.
Use configurable group as well
| Configurable<bool> doAntilambdav0radiusCut{"doAntilambdav0radiusCut", true, "Enable AntiLambda v0radius Topological Cut"}; | ||
| Configurable<bool> doAntilambdadcaposdautopv{"doAntilambdadcaposdautopv", true, "Enable AntiLambda DCA pos daughter to PV Topological Cut"}; | ||
| Configurable<bool> doAntilambdadcanegdautopv{"doAntilambdadcanegdautopv", true, "Enable AntiLambda DCA neg daughter to PV Topological Cut"}; | ||
| struct AntiLambdaSelectionConfig { |
Collaborator
There was a problem hiding this comment.
Use configurable group as well
romainschotter
approved these changes
Oct 2, 2026
romainschotter
enabled auto-merge (squash)
October 2, 2026 11:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated Real-Derived-Data process, updated RecoMC-Derived-Process and added GenMC-Derived-Process and MC-Closure-Test process.