Skip to content

[PWGCF] Fix fetching CCDB data bug and improvements - #18166

Merged
abilandz merged 1 commit into
AliceO2Group:masterfrom
meiALICE:master
Oct 4, 2026
Merged

abilandz merged 1 commit into
AliceO2Group:masterfrom
meiALICE:master

Conversation

@meiALICE

@meiALICE meiALICE commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

Fix a bug where the task fetch data from CCDB multiple times, which results in a crash

Make a full use of struct TaskConfiguration {...} tc;

obs.fProfTwo[eSim] is now filling the correct simulated centrality

@github-actions github-actions Bot added the pwgcf label Oct 4, 2026
@github-actions github-actions Bot changed the title Fix fetching CCDB data bug and improvements [PWGCF] Fix fetching CCDB data bug and improvements Oct 4, 2026
@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@abilandz
abilandz merged commit 46423fd into AliceO2Group:master Oct 4, 2026
13 of 14 checks passed
@alibuild

alibuild commented Oct 4, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 260937a at 2026-10-04 20:09:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 1 errors and 8 warnings.'
Found 1 errors and 8 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/da0fcccd7921ceffd36834084aaf0e8f6e167f73/O2Physics-code-check/errors.txt
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsMei.cxx:246:10: error: Excessive padding in 'struct MultiparticleCorrelationsMei::TaskConfiguration' (43 padding bytes, where 3 is optimal). Optimal fields order: fSigmaInel, fTechnicalCutSwitch, fVertexZCutRange, fCentCutRange, fPtCutRange, fEtaCutRange, fFileWithWeights, fCentralityEstimator, fMultiplicityTables, fDryRun, fExternalFileSwitch, fALICECentBinSwitch, fMasterCutSwitch, fEventCutSwitch, fPtCutSwitch, fEtaCutSwitch, fChargeCutSwitch, fQualityAssuranceSwitch, fRunMessageSwitch, fProcess, consider reordering the fields or adding explicit padding members [clang-analyzer-optin.performance.Padding,-warnings-as-errors]
++ [[ 8 -gt 0 ]]
++ cat /sw/BUILD/da0fcccd7921ceffd36834084aaf0e8f6e167f73/O2Physics-code-check/warnings.txt
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsMei.cxx:882:13: warning: member 'runMessagePeriod' of type 'const int' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsMei.cxx:1183:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsMei.cxx:1225:162: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsMei.cxx:1255:161: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsMei.cxx:1287:158: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsMei.cxx:1317:157: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsMei.cxx:1355:141: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsMei.cxx:1365:139: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
++ [[ 1 -gt 0 ]]
++ exit 1
--

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants