Conversation
|
O2 linter results: ❌ 0 errors, |
| fitter.setCollinear(collinear); | ||
| int nCand = 0; | ||
| try { | ||
| nCand = fitter.process(posTrackParCov, negTrackParCov); |
There was a problem hiding this comment.
Hi @hfribert ! It looks good. However, it is not clear to me how this is different than what is currently being done in the propagationService. Can you please elaborate a bit more?
Maybe we could discuss it tomorrow at the PAG-Strangeness meeting?
Thank you very much!
There was a problem hiding this comment.
Hi @romainschotter, thanks for having a look! The propagationService, as far as I saw, takes the SVertexer V0s as input. The SVertexer however applies cuts towards the primary vertex (e.g. mTPCTrackMaxDCAXY2ToMeanVertex), which seem to be too tight for many of the Sigma+ decays (after a couple of cm's). Many of these photons therefore wouldn't be available via the propagationService V0s.
| for (int iCand = 0; iCand < static_cast<int>(mCandidatesOfTimeframe.size()); ++iCand) { | ||
| candsByPhoton[mCandidatesOfTimeframe[iCand].photonId].push_back(iCand); | ||
| } | ||
| std::vector<bool> keep(mCandidatesOfTimeframe.size(), !candDeduplicatePhotons); |
There was a problem hiding this comment.
In propagationService, deduplication is performed at the photon-building stage, whereas here it is done on the photon mother (the Sigma). Is there a specific reason or benefit to handling it this way?
Thank you very much!
There was a problem hiding this comment.
The reason to deduplicate using the mother is that the photon does not point to the PV. For photon-based deduplication, I would also need to use the proton daughter, e.g., the CPA of the photon to the decay vertex (p + 2gamma). I also tried deduplicating using the proton-photon dca, which seems to yield fewer true candidates than taking the reconstructed mother dca-to-PV as a criterion.
romainschotter
left a comment
There was a problem hiding this comment.
(sorry misclick)
|
Error while checking build/O2Physics/code-check for 3502361 at 2026-10-05 21:32: Full log here. |
@fmazzasc
This PR adds the option to build the photon candidates itself instead of using V0Datas: