Skip to content

[PWGEM] Fix code check errors - #18223

Merged
jokonig merged 1 commit into
AliceO2Group:masterfrom
jokonig:master
Oct 9, 2026
Merged

jokonig merged 1 commit into
AliceO2Group:masterfrom
jokonig:master

Conversation

@jokonig

@jokonig jokonig commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator

@github-actions github-actions Bot added pwgem photon Photon and neutral meson PAG label labels Oct 8, 2026
@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 145 warnings, 🔕 27 disabled

- Fix missing includes or remove unnecessary includes
- Add safeguard to still use global using declaration (since its not a real header file, its okay to define using globally)
- partially introduced in AliceO2Group#17787
@jokonig
jokonig marked this pull request as ready for review October 9, 2026 07:33
@jokonig
jokonig enabled auto-merge (squash) October 9, 2026 13:13

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @jokonig.

@jokonig
jokonig merged commit d3c92c5 into AliceO2Group:master Oct 9, 2026
15 checks passed
@vkucera

vkucera commented Oct 14, 2026

Copy link
Copy Markdown
Collaborator

Hi @jokonig , thanks for the adjustment.
I don't understand why you say that "it's not a real header file" though.

@jokonig

jokonig commented Oct 14, 2026

Copy link
Copy Markdown
Collaborator Author

Hi @vkucera
What I meant with that is that the photon-conversion-builder and dalitz-skimmer are in principle tasks. However, since we had to template it to allow the same task to handle different tables as input, we moved the task into a header file to have two different .cxx files to call it with different template arguments.
Of course, it is a header file, but its not a header file that is used by different user tasks etc. and hence we thought it is okay to keep the global namespaces.

@vkucera

vkucera commented Oct 14, 2026

Copy link
Copy Markdown
Collaborator

Hi @vkucera What I meant with that is that the photon-conversion-builder and dalitz-skimmer are in principle tasks. However, since we had to template it to allow the same task to handle different tables as input, we moved the task into a header file to have two different .cxx files to call it with different template arguments. Of course, it is a header file, but its not a header file that is used by different user tasks etc. and hence we thought it is okay to keep the global namespaces.

OK, thanks for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

photon Photon and neutral meson PAG label pwgem

Development

Successfully merging this pull request may close these issues.

3 participants