Skip to content

[PWGHF] Cut variation: demote efficiency vector non-monotonicity to warning; fix bug and format - #18447

Merged
fgrosa merged 5 commits into
AliceO2Group:masterfrom
lubynets:cut-var
Nov 2, 2026
Merged

[PWGHF] Cut variation: demote efficiency vector non-monotonicity to warning; fix bug and format#18447
fgrosa merged 5 commits into
AliceO2Group:masterfrom
lubynets:cut-var

Conversation

@lubynets

@lubynets lubynets commented Oct 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • non-monotonicity of the vector of efficiencies is demoted to a warning (before it was an error) in order to tolerate rare, but possible case, when two neighboring selections have the same prompt efficiency and different nonpromt (or other way around). The warning is printed in execution time, and minimization status histogram is filled accordingly;
  • fixed bug introduced in [PWGHF] Cut variation: add efficiency-related functional #17929 when dictionary was accessed with values() instead of items(), but was still assigned to a pair of objects;
  • applied ruff format.

@github-actions github-actions Bot added the pwghf PWG-HF label Oct 23, 2026
@github-actions

github-actions Bot commented Oct 23, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Cut variation: demote efficiency vector non-monotonicity to warning; fix bug and format [PWGHF] Cut variation: demote efficiency vector non-monotonicity to warning; fix bug and format Oct 23, 2026
@fgrosa
fgrosa merged commit c122ce8 into AliceO2Group:master Nov 2, 2026
16 checks passed
@lubynets
lubynets deleted the cut-var branch November 2, 2026 17:43
@lubynets lubynets mentioned this pull request Nov 2, 2026
Closed
1 task done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fgrosa fgrosa fgrosa approved these changes
@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner
@vkucera vkucera Awaiting requested review from vkucera vkucera is a code owner
@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner
@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner
@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner
@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner
@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner
@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner
@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner
@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner
@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner
@zhangbiao-phy zhangbiao-phy Awaiting requested review from zhangbiao-phy zhangbiao-phy is a code owner
@gluparel gluparel Awaiting requested review from gluparel gluparel is a code owner
@stefanopolitano stefanopolitano Awaiting requested review from stefanopolitano stefanopolitano is a code owner
@xinyepeng xinyepeng Awaiting requested review from xinyepeng xinyepeng is a code owner
@singhra1994 singhra1994 Awaiting requested review from singhra1994 singhra1994 is a code owner

Assignees

No one assigned

Labels

pwghf PWG-HF

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lubynets @fgrosa