Skip to content

Group candidate duplicates before comparing recipes - #144

Closed
BonsUnleashed wants to merge 1 commit into
AlmostReliable:1.20.1from
BonsUnleashed:bons-furious/almostunified-duplicate-groups
Closed

BonsUnleashed wants to merge 1 commit into
AlmostReliable:1.20.1from
BonsUnleashed:bons-furious/almostunified-duplicate-groups

Conversation

@BonsUnleashed

Copy link
Copy Markdown

The duplicate pass compares each changed recipe with every recipe of its type. Most pairs cannot match because their compared fields, values or crafting outputs differ. This groups recipes by those necessary conditions and leaves Almost Unified's existing comparison to decide the matches within each group.

The groups retain recipe order. Ignored fields and sanitizing settings shape the grouping, and hash collisions still receive the full comparison. Crafting outputs are first read in the same sequence, preserving warnings and failures. The index belongs to one duplicate pass and is discarded before the next reload.

I developed the underlying change for Bons and Furious 1.0.29 and carried it into the upcoming 1.0.30 release. For this port, a differential check using the compiled upstream recipe code compared 47,206 recipe checks across 595 type/config combinations, including strict and sanitizing configurations. Duplicate links, master choices, cached outputs, warnings and exceptions matched. Focused cases also covered shaped recipes, implicit counts and malformed data.

:Common:compileJava and :Forge:compileJava passed on Java 17. These are offline correctness checks; I have not measured overall startup time with this upstream build.

@rlnt

rlnt commented Oct 4, 2026

Copy link
Copy Markdown
Member

AI slop

@rlnt rlnt closed this Oct 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants