Repository navigation
Group candidate duplicates before comparing recipes - #144
Closed
BonsUnleashed wants to merge 1 commit into
Closed
BonsUnleashed wants to merge 1 commit into
BonsUnleashed wants to merge 1 commit into
Conversation
Member
|
AI slop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The duplicate pass compares each changed recipe with every recipe of its type. Most pairs cannot match because their compared fields, values or crafting outputs differ. This groups recipes by those necessary conditions and leaves Almost Unified's existing comparison to decide the matches within each group.
The groups retain recipe order. Ignored fields and sanitizing settings shape the grouping, and hash collisions still receive the full comparison. Crafting outputs are first read in the same sequence, preserving warnings and failures. The index belongs to one duplicate pass and is discarded before the next reload.
I developed the underlying change for Bons and Furious 1.0.29 and carried it into the upcoming 1.0.30 release. For this port, a differential check using the compiled upstream recipe code compared 47,206 recipe checks across 595 type/config combinations, including strict and sanitizing configurations. Duplicate links, master choices, cached outputs, warnings and exceptions matched. Focused cases also covered shaped recipes, implicit counts and malformed data.
:Common:compileJavaand:Forge:compileJavapassed on Java 17. These are offline correctness checks; I have not measured overall startup time with this upstream build.