Repository navigation
Keep ME Requester crafting plans off the server thread - #76
Chronic-Reflexes wants to merge 1 commit into
Conversation
AE2 parks the server tick while a requester plan runs. These plans now keep working on the calculator thread, and pattern-map updates wait until they are paused. Co-authored-by: Cursor <cursoragent@cursor.com>
|
We do not accept AI slop. |
|
ai "slop" or not there is a large performance increase with the changes that have been made, its unfortunate you'd put your personal distaste of ai over the performance of the mod |
|
I have nothing against AI. However, I do have a problem with entirely AI generated code where the author has no idea what they are doing, especially when they expect me to spend my free time reviewing code they haven't invested a single minute in understanding. You mixin into Applied Energistics internals without questioning it (as agents often do, they like hacky mixins) and then presented me with this collection of hacks. On top of that, you provided no technical explanation of why this would be the best solution, how exactly the code works, or why it would actually resolve the performance issues. Posting an additional explanation on Discord is not particularly helpful. That information belongs in this post: profiling reports, explanations of your approach, and references to specific changes. Instead, you essentially say, "Here you go, deal with it," shifting all the time and effort onto me. You don't respect my time, so I don't respect your contribution. In my response to your Discord post, I also made it clear that I would look into the performance issues, but that I would definitely not accept your code. Now that the issue has been brought to my attention, I can work on it, but deciding which code I accept remains my decision. Since you seem unable to understand this simple concept and have instead resorted to a personal attack, you are hereby blocked from the organization. |
Summary
simulateForwait. They keep running on the calculator thread and pause on AE2's normal time budget.The same fix has been made for the latest
26.1branch. It is not included here because that version cannot be tested at the moment.Test plan
26.1build was not runMade with Cursor