Skip to content

Log the first failed CAS blob publication attempt below Warning - #2594

Open
filimonov wants to merge 1 commit into
antalya-26.6-20261008from
fix/antalya-26.6/cas-blob-attempt-log-level
Open

filimonov wants to merge 1 commit into
antalya-26.6-20261008from
fix/antalya-26.6/cas-blob-attempt-log-level

Conversation

@filimonov

Copy link
Copy Markdown
Member

The per-attempt CasBlobPublishAttempt warning of #2555 reached clients with send_logs_level=warning and failed two stateless tests on stderr in stateless asan cas s3 2/2: 02907_filter_pushdown_crash and 03254_pr_join_on_dups. Both saw Publication of CAS blob ... failed, attempt 1 of 8: ... Connection refused; attempt 2 succeeded.

The first failed attempt is now logged at Information. Attempt 2 and later, and the give-up path, stay at Warning. CASBlobPublishAttemptFailed and CASBlobPublishGaveUp are unchanged.

Test: CASBlobPublishTransport.FirstFailedAttemptIsBelowWarning drops two PutObject responses and checks that attempt 1 is absent and attempt 2 present in a Warning-level capture. It failed before the change (attempt 1 logged once).

Related: #2555

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

CAS blob publication logs the first failed attempt at Information instead of Warning, so a single retried failure no longer reaches clients that request warning-level logs.

Documentation entry for user-facing changes

  • Not needed: the docs do not state the log level.

CI/CD Options

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Unit tests
  • Performance tests
  • Aarch64 tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All Regression
  • Disable CI Cache

Regression jobs to run:

  • Fast suites (mostly <1h)
  • Aggregate Functions (2h)
  • Alter (1.5h)
  • Benchmark (30m)
  • CAS (content-addressed storage; Antalya only)
  • ClickHouse Keeper (1h)
  • Iceberg (2h)
  • LDAP (1h)
  • OAuth (5m)
  • Parquet (1.5h)
  • RBAC (1.5h)
  • SSL Server (1h)
  • S3 (2h)
  • S3 Export (2h)
  • Swarms (30m)
  • Tiered Storage (2h)

A lone failed attempt (for example a refused connection) is retried and usually
succeeds, but the per-attempt warning reached clients with send_logs_level=warning
and failed stateless tests on stderr. Attempt 1 now logs at Information; attempt 2
and later stay at Warning. CASBlobPublishAttemptFailed and CASBlobPublishGaveUp
are unchanged.

Related: #2555

Signed-off-by: Mikhail Filimonov <mfilimonov@altinity.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

Workflow [PR], commit [6a1085e]

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant