Repository navigation
Conversation
A lone failed attempt (for example a refused connection) is retried and usually succeeds, but the per-attempt warning reached clients with send_logs_level=warning and failed stateless tests on stderr. Attempt 1 now logs at Information; attempt 2 and later stay at Warning. CASBlobPublishAttemptFailed and CASBlobPublishGaveUp are unchanged. Related: #2555 Signed-off-by: Mikhail Filimonov <mfilimonov@altinity.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The per-attempt
CasBlobPublishAttemptwarning of #2555 reached clients withsend_logs_level=warningand failed two stateless tests on stderr instateless asan cas s3 2/2:02907_filter_pushdown_crashand03254_pr_join_on_dups. Both sawPublication of CAS blob ... failed, attempt 1 of 8: ... Connection refused; attempt 2 succeeded.The first failed attempt is now logged at Information. Attempt 2 and later, and the give-up path, stay at Warning.
CASBlobPublishAttemptFailedandCASBlobPublishGaveUpare unchanged.Test:
CASBlobPublishTransport.FirstFailedAttemptIsBelowWarningdrops twoPutObjectresponses and checks that attempt 1 is absent and attempt 2 present in a Warning-level capture. It failed before the change (attempt 1 logged once).Related: #2555
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
CAS blob publication logs the first failed attempt at Information instead of Warning, so a single retried failure no longer reaches clients that request warning-level logs.
Documentation entry for user-facing changes
CI/CD Options
Exclude tests:
Regression jobs to run: