Repository navigation
Type the operand of ValueProxy.eq and ValueProxy.ne #47
Description
The guardrail ratchet of @antelopejs/interface-database (main at fc1ba44) holds two contract findings in the published ValueProxy class (/valueproxy and /staged-query subpaths):
| file:line | rule | exported item | proposed change | why a refactor cannot do it |
|---|---|---|---|---|
| src/staged-query/valueproxy.ts:124 | anti-slop/no-unknown-parameters | ValueProxy<T>.eq(value: unknown) |
eq(value: ValueProxyOrValue<T>) (or the package's Value type over T), like gt/lt already constrain their operand |
the parameter is in the published declaration; narrowing it rejects callers comparing across types, so it is a breaking change for consumers (new minor) |
| src/staged-query/valueproxy.ts:134 | anti-slop/no-unknown-parameters | ValueProxy<T>.ne(value: unknown) |
same as eq |
same |
The other five ratcheted findings are legitimate and stay:
src/staged-query/datum.ts:23,src/staged-query/stream.ts:24,src/staged-query/valueproxy.ts:69(no-chained-type-assertions):cast<U>()returns the same object retyped; a singleasfails TS2352 and a fresh object would change identity.src/tests/atomic_mutation.test.ts:109,:202(require-safety-comment-for-type-assertion): deliberately invalid inputs that proveValidateAtomicMutationthrows at run time.
Activity
Upd4ting commentedon Nov 4, 2026
Fixed by #62 (typed query operands), on main in 1cf8db2 (#71).
ValueProxy.eqandnenow takeEqualityOperand<T>(src/staged-query/valueproxy.ts:121 and :131). Checked by reading main.