Repository navigation
fix(skills): route decorator table classes away from database-interface - #75
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The eval case
database-interface-decorators-neighbourflipped between runs with no description change. This PR makes it pass on every run. The case asks for a decorator-based table class and expectsdatabase-decorators-interfacewithoutdatabase-interface. Sonnet often loaded both, because this skill's description claims "Table" and "define a database schema" and does not mention its neighbour.Goal
The neighbour case passes on every run. Prompts that
database-interfaceowns keep loading it.Done means
database-interfacedescription routes declarations of decorator table and model classes todatabase-decorators-interface, and keeps AQL queries on those tables.mainflips.main, and the eval report scored againstmainis PASS.pnpm run checkspasses, and CI is green.Change
One line in
skills/database-interface/SKILL.md, thedescription:RegisterTable,Field,Index,Fixture,Encrypted,Hashed,BasicDataModel) and points todatabase-decorators-interface. All seven are real exports of that package. Another sentence keeps AQL queries on their tables here, becauseBasicDataModelexposes an AQLtable.The description is 889 characters, under the 1024 limit.
Verification
Local evals with
scripts/evals.mjsof the AntelopeJS plugin 0.7.0, published corpus plus this package's skills. The 10 cases ofdatabase-interfaceanddatabase-decorators-interfaceran onclaude-opus-5-5-lowandclaude-sonnet-5-5-low.main--againstamainrun is PASS.database-interface-duplicate-keyloadeddatabase-interfacein every run, so listingIndexdoes not pull that case away.mainalike. It isdatabase-decorators-interface-modifiers, where the name check counts a relative import path (../db/user) as an invented name. That case belongs to the neighbour package and this change does not touch it.codex-gptwas not run: the Codex CLI is not installed on the machine that ran these evals. The skill-eval gate run should cover it.pnpm run checks:Checks: 8 passed, 0 failed.