Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion spotapi/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,10 @@ def _parser() -> argparse.ArgumentParser:
search.add_argument("--type", choices=tuple(SEARCH_DESKTOP_SECTIONS), default="track")
search.add_argument("--limit", type=_limit, default=10)
search.add_argument("--json", action="store_true", help="print results as JSON")
search.add_argument(
"--language",
help="language or locale for results, such as fr-CA",
)
get = commands.add_parser("get", help="look up a Spotify URL or URI as JSON")
get.add_argument("resource", help="Spotify URL or URI")
credits = commands.add_parser("credits", help="show a track's contributors as JSON")
Expand Down Expand Up @@ -134,7 +138,7 @@ async def _search(args: argparse.Namespace) -> None:
kind: SearchKind = args.type
if sys.stderr.isatty():
print("Searching Spotify... First-time setup may take a moment.", file=sys.stderr)
results = await Public.search(args.query, types=kind, limit=args.limit)
results = await Public.search(args.query, types=kind, limit=args.limit, language=args.language)
hits = results[kind]
if args.json:
_json(hits)
Expand Down
25 changes: 25 additions & 0 deletions tests/test_cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -138,3 +138,28 @@ async def session(cookie: str) -> AsyncGenerator[object, None]:
assert main(["playlist", "move", "playlist", "second", "--before", "first"]) == 0
move.assert_awaited_once_with("second", before="first", after=None)
assert not capsys.readouterr().out


def test_cli_search_forwards_language(
monkeypatch: pytest.MonkeyPatch, capsys: pytest.CaptureFixture[str]
) -> None:
mock_search = AsyncMock(return_value=SearchResults("Charlotte Cardin", ("track",)))
monkeypatch.setattr(Public, "search", mock_search)

assert main(["search", "Charlotte Cardin", "--language", "fr-CA"]) == 0
mock_search.assert_awaited_once()
call_kwargs = mock_search.await_args.kwargs
assert call_kwargs["language"] == "fr-CA"
assert call_kwargs["query"] == "Charlotte Cardin"


def test_cli_search_omits_language_by_default(
monkeypatch: pytest.MonkeyPatch, capsys: pytest.CaptureFixture[str]
) -> None:
mock_search = AsyncMock(return_value=SearchResults("abc", ("track",)))
monkeypatch.setattr(Public, "search", mock_search)

assert main(["search", "abc"]) == 0
mock_search.assert_awaited_once()
call_kwargs = mock_search.await_args.kwargs
assert call_kwargs.get("language") is None