Conversation
Signed-off-by: Jairus Tanaka <me@jairus.dev>
Signed-off-by: Jairus Tanaka <me@jairus.dev>
Signed-off-by: Jairus Tanaka <me@jairus.dev>
JairusSW
marked this pull request as draft
June 9, 2026 06:04
JairusSW
marked this pull request as ready for review
June 17, 2026 18:13
|
Just curious here, why the exception of a trailing .0? |
Contributor
Author
Max and Dan made that decision so that floats are easily identifiable when converting them to a string. For example, you know that the string |
Member
|
Can you rename xjb.ts to dtoa.ts and in comments mentioned about implementation based on xjb and zmij? |
MaxGraey
reviewed
Jun 17, 2026
MaxGraey
reviewed
Jun 17, 2026
MaxGraey
reviewed
Jun 17, 2026
MaxGraey
reviewed
Jun 17, 2026
MaxGraey
reviewed
Jun 17, 2026
Co-authored-by: Max Graey <maxgraey@gmail.com>
Co-authored-by: Max Graey <maxgraey@gmail.com>
MaxGraey
reviewed
Jun 17, 2026
MaxGraey
reviewed
Jun 17, 2026
MaxGraey
reviewed
Jun 17, 2026
MaxGraey
reviewed
Jun 17, 2026
MaxGraey
reviewed
Jun 17, 2026
Co-authored-by: Max Graey <maxgraey@gmail.com>
dcodeIO
reviewed
Jun 17, 2026
MaxGraey
reviewed
Jun 17, 2026
Co-authored-by: Max Graey <maxgraey@gmail.com>
MaxGraey
reviewed
Jun 18, 2026
MaxGraey
reviewed
Jun 18, 2026
MaxGraey
reviewed
Jun 18, 2026
MaxGraey
reviewed
Jun 18, 2026
MaxGraey
reviewed
Jun 18, 2026
MaxGraey
reviewed
Jun 18, 2026
MaxGraey
reviewed
Jun 18, 2026
MaxGraey
reviewed
Jun 18, 2026
MaxGraey
reviewed
Jun 18, 2026
Member
|
Also plz add extra tests which cover new implementation-specific edge cases (I anready found a bug) and uncomment existing test cases which failed with grisu2 |
…ript into jairus/switch-to-xjb
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3012.
Changes proposed in this pull request:
.0It's good quality stuff though, and I'm quite confident in that.
Earlier main-vs-PR formatter measurements, before the exact-integer string path (10m iterations per cycle):
mainf64buffered, ns/valuef32buffered, ns/valuef64string-returning, ns/valuef32string-returning, ns/valueEarlier generated code size, before the exact-integer string path (a
mainfunction callingdtoa/ftoa):mainf64onlyf32onlyMost of this is the formatter which is now ECMA262 compliant, so, it's more complicated.
The actual tables are
910 bytes(before) vs872 bytes(this pr)