Skip to content

fix: improve Herman portrait framing on the team page #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chengjiahao1234 merged 1 commit into from
Oct 1, 2026
Merged

fix: improve Herman portrait framing on the team page #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions _data/phd_students.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
#
# Optional Fields:
# - photo: Filename in /images/teampic/ (default: bio-photo.jpg)
# - photo_position: Optional CSS object-position for portrait framing
# - info: Role/title (e.g., "PhD Student", "PhD Candidate")
# - short_bio: Brief description (not currently displayed)
# - email: Email address
Expand Down Expand Up @@ -95,6 +96,7 @@

- name: Herman Tcheneghon Motcheyo
photo: herman_tcheneghon_motcheyo.jpg
photo_position: "center top"
info: PhD Student
email: "herman.tcheneghonmotcheyo@mail.concordia.ca"
# Alternative email (not displayed): hermanmotcheyo@gmail.com
Expand Down
3 changes: 2 additions & 1 deletion _includes/team-grid.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
- name: "Jane Doe" (required)
- info: "PhD Student" (optional)
- photo: "jane.jpg" (optional; falls back to bio-photo.jpg)
- photo_position: "center top" (optional; defaults to centered cropping)
- email / github / linkedin / google_scholar / orcid / twitter (optional)
- links: (optional; array of {url,type,label,icon})
- { url: "https://...", type: "website" }
Expand Down Expand Up @@ -48,7 +49,7 @@

<article class="team-card">
<div class="team-photo">
<img src="{{ photo_path }}" alt="Portrait of {{ member.name | escape }}">
<img src="{{ photo_path }}" alt="Portrait of {{ member.name | escape }}"{% if member.photo_position and photo_exists %} style="object-position: {{ member.photo_position | escape }};"{% endif %}>
</div>

<div class="team-body">
Expand Down