Repository navigation
feat(mobile): manager mode behind mobile_manager_mode flag - #14756
Merged
Merged
Conversation
Managers can switch into accounts they manage from the left nav, and artists can invite and remove managers from Settings. Account switching restarts the app through a new optional AppContext.reloadApp; web keeps its page reload. While managing an account the app shows a Managed Account strip and an accented header avatar, and blocks DMs, purchases, buy/sell, sending coins, and the email, password, verification and delete account rows. The flag only gates the entry points, so switching back and the restrictions keep working if it is turned off. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings manager mode to mobile. Managers can switch into accounts they manage, and artists can invite and remove managers, without going to web.
Gated by the new
mobile_manager_modeflag (default off in prod, on in dev). The flag only hides the entry points. Switching back and the manager-mode restrictions stay on regardless, so turning the flag off can't strand someone inside another account.Changes
Switching
AppContextgets an optionalreloadApp. Mobile passesRNRestart.Restart(), anduseAccountSwitcheruses it instead ofwindow.location.reload(). Web is unchanged.AccountSwitcherdrawer listing your account plus the managed accounts you've approved.While managing an account
ChatList,Chat,ChatUserList) render a "not available" screen with a "Switch to My Account" button. The Messages nav item, share-to-DM and the profile message button are hidden.Settings screens (ported from the web modals)
/settings/accounts-you-manageand/settings/managing-youopen these screens when the flag is on. Otherwise the old "Available on web" drawer still shows. RequestManager and ApproveManagerRequest notifications open them too.Testing
Tested on an iOS 26.5 simulator with a Release build and a swapped JS bundle:
useIsManagedAccounttemporarily forced true: the Managed Account strip, the avatar ring, the switcher drawer, and hidden Messages, Inbox Settings and account credential rows.Fixed during testing: drawers rendered under the floating tab bar (now portaled to
DrawerPortal), and the keyboard covered the confirm drawer.Android (API 36 emulator, debug APK on this branch's JS):
RNRestartpath.Not tested:
Typecheck and lint pass for mobile and web. Common has one existing test-file error that's also on main.
🤖 Generated with Claude Code