Skip to content

Sign Safari into Drive and re-wrap the vault key - #1605

Open
theodosiskats wants to merge 1 commit into
Authenticator-Extension:devfrom
theodosiskats:safari-drive-backup
Open

Sign Safari into Drive and re-wrap the vault key#1605
theodosiskats wants to merge 1 commit into
Authenticator-Extension:devfrom
theodosiskats:safari-drive-backup

Conversation

@theodosiskats

@theodosiskats theodosiskats commented Nov 4, 2026 •
edited
Loading

Copy link
Copy Markdown

Summary

  • Rebased onto current dev. The pull request was 92 commits behind, and the old branch could not merge.
  • Safari signs in through the Mac app, because Safari cannot finish https://authenticator.cc/oauth itself. The client id and secret in credentials.ts stay empty. Dropbox and OneDrive stay hidden on Safari.
  • The Argon2id vault-key rewrite from the first version of this branch is not included. Current dev already stores keys differently, and that old wrap does not fit it.

Test plan

  • npm run safari compiles on current dev.
  • Sign-in still fails until the release script fills the Drive client id and secret.
  • A signed Mac build still has to catch the callback. This repository does not include that app.

@theodosiskats theodosiskats mentioned this pull request Nov 4, 2026
Open
2 tasks done
@theodosiskatsoulis
Sign Safari into Drive on top of the current extension.
dd6a4c9 
Safari still cannot finish the https callback itself, so the Mac app does. Dropbox and OneDrive stay hidden there. The vault-key rewrite from the old branch is gone, because dev already uses a different key model.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@theodosiskats @theodosiskatsoulis