Skip to content

fix(erc-8350): sync editor revision and complete conformance inputs - #25

Merged
everest-an merged 1 commit into
mainfrom
fix/editor-review-113
Sep 17, 2026
Merged

everest-an merged 1 commit into
mainfrom
fix/editor-review-113

Conversation

@XiaoHai67890

Copy link
Copy Markdown
Collaborator

Change

Synchronize the Office Hour #113 editor revision for ethereum/ERCs#1910 into the product's ERC mirror and strengthen v1 conformance coverage.

  • Apply CC0-1.0 only to the three submitted Solidity assets and their mirrors. Product sources and TypeScript packages retain Apache-2.0.
  • Limit Reference Implementation wording to assets included in the official submission; add RFC 2119/8174 links.
  • Add the two authorization type strings and explicit newController/newAuthorizer inputs to the v1 vector. Existing expected hashes are unchanged.
  • Mark four extra interface helpers optional and non-normative; preserve the ABI and normative deriveSpaceId.
  • Synchronize Sam's earlier revision and remove the duplicate ERC-1271 asset.
  • Exercise the submitted Solidity registry as well as the product registry in the Golden Vector suite.

Verification

Source: 2982461374d84b37215c95bbc36c0e61ea8d61ef

  • PASS: pnpm conformance:clean from a clean detached checkout using Node 22.23.2, pnpm 11.7.0, Foundry 1.7.1 and Solidity 0.8.24.
  • PASS: 57 TypeScript tests and 71 Solidity tests.
  • PASS: core TS, minimal TS and Solidity match test-vectors/v1.json byte-for-byte; the Solidity suite also runs against the submitted asset.
  • PASS: 8 missing/tampered-input cases rejected by all three suites (24 negative runs); restored vectors pass again.
  • PASS: official document EIP Walidator, Markdownlint and Codespell checks.
  • Vector SHA-256: 5e04cb9c1181222f483d3ad547e0a9aa301dfab74c7028f3cfa2e5dcd574fc20.

Boundaries

No protocol hash algorithm or state-machine behavior is changed. Frozen G4 evidence is preserved and does not constitute an audit of this revision. No deployment is changed. Local results do not imply GitHub CI approval or Editor approval. Dependency audit is not included in the local conformance claim.

Revision mapping and reproduction instructions: docs/reviews/office-hour-113.md.

@everest-an
everest-an merged commit bf89c0b into main Sep 17, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants