Repository navigation
feat: verify Helm downloads and support fallback mirrors - #315
Open
David Gamero (davidgamero) wants to merge 3 commits into
Open
David Gamero (davidgamero) wants to merge 3 commits into
David Gamero (davidgamero) wants to merge 3 commits into
Conversation
David Gamero (davidgamero)
force-pushed
the
verify-downloads-and-fallback
branch
from
November 5, 2026 17:37
9cee81b to
a7f13d2
Compare
Suneha Bose (bosesuneha)
approved these changes
Nov 6, 2026
Suneha Bose (bosesuneha)
left a comment
Suneha Bose (bosesuneha)
left a comment
Member
There was a problem hiding this comment.
Documenting that this changes v5 behavior: fresh downloads require matching .sha256 files. Archive-only custom mirrors must add them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
downloadBaseURLFallbackmirror and require the fallback archive to pass the same verificationSecurity
Checksums are downloaded from the same base URL as their archive. Missing, malformed, or mismatched checksums fail closed. When a fallback mirror is configured, both its archive and checksum must download successfully and match before extraction.
Validation
npm test(62 passing)npm run typechecknpm run format-checknpm run buildnpm audit --audit-level=low(0 vulnerabilities)git diff --checkactionlintstill reports the repository's existing missinglib/index.jssource-tree warning and deprecated integration-test token input; neither is introduced by this change.