fix(deploy): respect resource group when selecting app - #1012
Open
Andrea Ceroni (andrekiba) wants to merge 1 commit into
Open
Andrea Ceroni (andrekiba) wants to merge 1 commit into
Andrea Ceroni (andrekiba) wants to merge 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Andrea Ceroni (andrekiba)
requested review from
Long Hao (LongOddCode),
Jikun (cjk7989) and
jessieyyt
as code owners
September 28, 2026 08:31
Copilot started reviewing on behalf of
Andrea Ceroni (andrekiba)
September 28, 2026 08:32
View session
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Fixes Static Web App selection by honoring the requested --resource-group during deployment.
Changes:
- Passes the resource group when listing Static Web Apps.
- Adds regression coverage for resource-group-scoped lookup.
| File | Description |
|---|---|
src/core/account.ts |
Filters site selection by resource group. |
src/core/account.spec.ts |
Tests lookup within the requested resource group. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Author
|
@microsoft-github-policy-service agree |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--resource-groupvalue during deploy login/setup.Fixes #958
Validation
npm test -- src/core/account.spec.ts src/cli/commands/deploy/deploy.spec.tsnpm run build