Repository navigation
refactor: 컨트롤러 반환 형식을 ResponseEntity로 맞춘다 - #161
Merged
Merged
Conversation
auth·member 관례(ADR-022)대로 본문을 직접 반환하던 52개 메서드를 ResponseEntity.ok(...)로 감싼다. @ResponseStatus를 쓰는 곳이 없어 이 메서드들은 원래 200이었고, 상태 코드와 본문은 그대로다.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 1 minute. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
… refactor/controller-response-entity # Conflicts: # src/main/java/com/bcsdlab/bcsdinternalapiv2/game/controller/GameApi.java # src/main/java/com/bcsdlab/bcsdinternalapiv2/home/controller/HomeApi.java # src/main/java/com/bcsdlab/bcsdinternalapiv2/track/controller/TrackApi.java
ff1451
marked this pull request as ready for review
October 18, 2026 13:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요약
*Api시그니처 포함)를 auth·member 관례대로ResponseEntity.ok(...)로 감쌌습니다.@ResponseStatus를 쓰는 곳이 없어 이 메서드들은 원래 200이었습니다. 상태 코드와 본문은 바뀌지 않습니다.머지 순서
#148~#157 머지 후 main으로 rebase하고 ready로 바꿉니다. 이 PR의 변경은 마지막 커밋 하나입니다. #160과
*Api파일 일부가 겹쳐서, 둘 중 나중에 머지하는 쪽은 rebase가 필요합니다(겹치는 부분은 서로 다른 줄입니다).검증