Repository navigation
feat(agents)!: adopt potr- namespace for crew templates - #25
NiccoloOlivieriAchille wants to merge 1 commit into
Conversation
Rename the four distributable Kiro agent templates to the potr- namespace, consistently across specs, prompts, skills, CLI, tests and docs: bepower-setup -> potr-setup functional-analyst -> potr-functional-analyst upgrade-guardian -> potr-upgrade-guardian rev-eng -> potr-rev-eng - git mv all agent/prompt files and the upgrade-guardian skill + functional-analyst resources dirs (history preserved) - update "name"/prompt/resources paths inside each spec - update CREW_AGENTS and all copy paths/logs in init-crew.ts / init-kiro.ts so members register under the new names - update test assertions and README / hooks docs CHANGELOG and version bump handled by release-please; dist/ regenerated via build (gitignored). BREAKING CHANGE: crew agent templates renamed to the potr- namespace; the previous names (bepower-setup, functional-analyst, upgrade-guardian, rev-eng) no longer resolve.
There was a problem hiding this comment.
Review Summary
This PR consistently applies the potr- namespace across all agent specs, prompts, skills, resources, CLI copy paths, tests, and docs. The rename is mechanically correct and the test suite assertions are all updated in sync with the implementation.
One defect found (must fix):
cli/commands/init-kiro.tslines 84–86: The post-install console summary only prints paths forpotr-setup.jsonandpotr-functional-analyst.json, silently omittingpotr-upgrade-guardian.jsonandpotr-rev-eng.json. All four agents are actually installed, but users will see an incomplete confirmation log that only shows 2 of 4 agents, which is misleading. A one-click fix suggestion has been added inline.
Everything else — the agent JSON specs, prompts, skill frontmatter, resource path references, CREW_AGENTS array, and all test assertions — is correctly and completely updated.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
| console.log(`\n Agents:`); | ||
| console.log(` ${join(kiroDir, 'agents/bepower-setup.json')}`); | ||
| console.log(` ${join(kiroDir, 'agents/functional-analyst.json')}`); | ||
| console.log(` ${join(kiroDir, 'agents/potr-setup.json')}`); | ||
| console.log(` ${join(kiroDir, 'agents/potr-functional-analyst.json')}`); |
There was a problem hiding this comment.
🛑 Logic Error: The success log only prints the install paths for potr-setup.json and potr-functional-analyst.json, omitting potr-upgrade-guardian.json and potr-rev-eng.json. All four agents are copied correctly above, but the console summary will tell users only 2 of 4 agents were installed, making the output misleading and potentially causing users to believe the install was incomplete or to re-run the command.
| console.log(`\n Agents:`); | |
| console.log(` ${join(kiroDir, 'agents/bepower-setup.json')}`); | |
| console.log(` ${join(kiroDir, 'agents/functional-analyst.json')}`); | |
| console.log(` ${join(kiroDir, 'agents/potr-setup.json')}`); | |
| console.log(` ${join(kiroDir, 'agents/potr-functional-analyst.json')}`); | |
| console.log(`\n Agents:`); | |
| console.log(` ${join(kiroDir, 'agents/potr-setup.json')}`); | |
| console.log(` ${join(kiroDir, 'agents/potr-functional-analyst.json')}`); | |
| console.log(` ${join(kiroDir, 'agents/potr-upgrade-guardian.json')}`); | |
| console.log(` ${join(kiroDir, 'agents/potr-rev-eng.json')}`); |
Summary
Rename the four distributable Kiro agent templates to adopt the
potr-namespace, consistently across specs, prompts, skills, CLI, tests and docs. Thepotr-namespace applies to the agents only — the package stays@bepower/dev.bepower-setuppotr-setupfunctional-analystpotr-functional-analystupgrade-guardianpotr-upgrade-guardianrev-engpotr-rev-engChanges
kiro/agents/*.json):git mv+ updatedname,promptpath, andresourcespath (functional-analyst).kiro/prompts/*.md):git mv+ updated textual self-references.kiro/skills/upgrade-guardian/→potr-upgrade-guardian/, withSKILL.mdfrontmatter + body references updated. The prompt points at the new skill name.kiro/resources/functional-analyst/→potr-functional-analyst/(5 templates).cli/commands/):CREW_AGENTSarray and every copy path / console log ininit-crew.tsandinit-kiro.ts— this is what registers crew members under the new names.test/): assertions updated to thepotr-names; suite stays green.README.md,kiro/hooks/README.md.All renames use
git mvto preserve history.Not touched (by design)
CHANGELOG.mdand the version bump are left to release-please (historical entries with the old names remain, legitimately).dist/is gitignored; it was regenerated vianpm run buildbut is not committed.Versioning
Committed as
feat(agents)!with aBREAKING CHANGE:footer, so release-please cuts a major release (3.1.1 → 4.0.0): the old agent names no longer resolve.Tested
npm run build✅npm run lint✅ (biome, lockfile-lint, npmPkgJsonLint, tsc --noEmit, ls-engines)npm test✅ 38/38CHANGELOG.md