Skip to content

feat(statics): add 9 goStocks test tokens from AMS - #10116

Merged
zeeshanamjad-eng merged 2 commits into
masterfrom
ams-bot-tokens
Nov 3, 2026
Merged

zeeshanamjad-eng merged 2 commits into
masterfrom
ams-bot-tokens

Conversation

@asset-metadata-bot

@asset-metadata-bot asset-metadata-bot Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Adds the 9 goStocks test tokens and their OFC variants to @bitgo/statics, as generated by asset-metadata-service:

Token OFC static id (AMS test) ofc id
tsol:aaplgo ofctsol:aaplgo ebd4f8c4-41f6-49e4-abed-e778db097e35 5dfa6d71-171a-4b9c-99ca-b972642fdc9c
tsol:amzngo ofctsol:amzngo 0bfa0bae-a7ff-4409-bd7f-f85415b313b6 02a72155-dae9-4f19-ac42-bde418efb7cc
tsol:googlgo ofctsol:googlgo 6576c5c9-0de9-4c35-be25-fe34019043eb fa55324e-00fa-4887-bc00-2319af2e50da
tsol:metago ofctsol:metago 2e614fad-abd8-4771-8a23-79e7381cd56c 26f59535-10e1-4d5f-9af3-956058a12b53
tsol:msftgo ofctsol:msftgo 9ed5bb47-44f5-475a-b837-06ce43b3eeaa 7e92c72d-9cd3-4cd2-b330-2a784e2c7560
tsol:nvdago ofctsol:nvdago 7c631f99-b96c-4c5d-adcf-578ef568c2f5 f6856f72-1523-4bef-8613-dbd71f8ca9b8
tsol:spcxgo ofctsol:spcxgo 990356b5-2726-481a-8a3d-27168c39b5db fcf9ca79-7af8-425f-8887-351862bb9ce5
tsol:spygo ofctsol:spygo 4efcd041-62a4-46ce-9425-f6d584782adb a268defe-db02-4089-9198-f707a04e21bf
tsol:tslago ofctsol:tslago 9fafac49-fc1a-4e96-8a38-45d55a844395 1b816f29-548d-469f-807d-341b9c7f70e8

Solana Token-2022, 9 decimals, features tokenized-equity + bitgo-tokenized-equity. Ids match the AMS test records, so statics and AMS agree on every asset id.

OFC fullNames use the clean form (Test NVIDIA, not ofcTest NVIDIA), matching the hand-written ofcCoins.ts convention and AMS's documented intent. The bot's amsCi source emits the ofc prefix; stripping it belongs in the AMS list/generator (follow-up).

Trimmed from the bot output

The bot's regeneration also removed hteth:WBTC, hteth:tgku, hteth:stzamakms (and their OFC variants) and STAKING on hteth:zamamock. Those were restored by hand in c47296c and their removal broke two statics unit tests. This PR now contains only the 18 goStock entries (added verbatim from the bot output); master's other entries are untouched. Root cause is being raised with the AMS team.

Verification

  • Diff vs master: 234 additions, 0 deletions, only the 18 entries above (byte-identical to the bot's generated blocks)
  • prettier --check clean, tsc --build clean
  • @bitgo/statics unit tests: 41,937 passing / 0 failing
  • OFC fullNames verified clean after the rename; base-coin names and ids unchanged
  • The restored coins and hteth:zamamock STAKING are still present

Ticket: STONKS-767

@asset-metadata-bot
asset-metadata-bot Bot requested a review from a team as a code owner November 2, 2026 16:39

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

⚠️ Compatibility checks are failing on Node.js 27-nightly (experimental, non-blocking). This does not block merge, but it signals an incompatibility to fix before this release becomes supported.

View run

@zeeshanamjad-eng

Copy link
Copy Markdown
Contributor

@claude review always

@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @zeeshanamjad-eng's task in 32s —— View job


Review of #10116 (AMS token onboarding)

Scope: botTokens.ts and botOfcTokens.ts only. This adds 9 tsol / ofctsol tokenized-equity tokens (nvdago, aaplgo, …). It removes hteth:WBTC, hteth:tgku and hteth:stzamakms with their OFC counterparts. It also reorders many OFC entries and drops CoinFeature.STAKING from one token.

I did not run the test suite. My local checkout's origin/master had no merge base with this branch, so I reviewed the PR's two commits directly.

Issue (likely test failure)

  • modules/statics/test/unit/base.ts:425: the test stZAMA LSTs should not expose STAKING calls coins.get('hteth:stzamakms'). This PR removes that coin, and a grep of modules/statics/src finds no other definition. coins.get will throw for the missing name, so this test should fail. Either remove 'hteth:stzamakms' from that list in the same PR, or restore the coin if the removal was unintended. Fix this →

Other notes

  • STAKING removal: one token in botTokens.ts (around line 404) loses CoinFeature.STAKING. The PR gives no reason for it. Please confirm it is intended, because it changes behavior for an existing token.
  • Removed tokens: hteth:WBTC and hteth:tgku have no other references in the repo, so those removals look clean. Removing a token from statics is a breaking change for anyone who resolves it by name, so confirm they are deprecated upstream.
  • New tsol tokens: they are consistent with each other. They use Token2022ProgramId, 9 decimals, and the tokenized-equity and bitgo-tokenized-equity features. Each has a matching ofctsol:* entry. I did not check the mint addresses against Solana devnet.
  • Duplicate check: I did not get a clean run of my duplicate ID/name check, so I can't rule out duplicates.
  • Node 27-nightly failure: the non-blocking compatibility check is unrelated to this change.

I can't submit a formal review or approve. @claude review always subscribes the PR to repeat reviews, which I can't set up from this comment.
· branch ams-bot-tokens

Comment thread modules/statics/src/coins/botTokens.ts Resolved
Comment thread modules/statics/src/coins/botTokens.ts Resolved
Add the tsol:*go test goStocks (aaplgo, amzngo, googlgo, metago, msftgo,
nvdago, spcxgo, spygo, tslago) and their ofctsol: OFC variants, as
generated by the asset-metadata-service bot. Static ids match the AMS
test records.

The bot's regeneration also dropped hteth:WBTC, hteth:tgku,
hteth:stzamakms (and OFC variants) and STAKING on hteth:zamamock, which
were restored by hand in c47296c. Those unrelated changes are left
out here so master's entries stay intact.

Ticket: STONKS-767
@zeeshanamjad-eng zeeshanamjad-eng changed the title feat: PR from asset-metadata-service for token onboardings feat(statics): add 9 goStocks test tokens from AMS Nov 3, 2026

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the updated version and didn't find any bugs. The diff now only adds tokens and no longer removes or edits existing ones. Both files belong to the statics code owners, so their review is still needed.

What was reviewed:

  • The nine new tsol:*go entries in botTokens.ts. Their names, UUIDs and mint addresses don't clash with the existing tsol:stg*go tokens in solTokens.ts. They also set TOKENIZED_EQUITY together with BITGO_TOKENIZED_EQUITY, which the base.ts validation requires.
  • The matching ofctsol:*go entries in botOfcTokens.ts. Leaving features undefined matches every other bot-generated OFC token. None of them sets tokenized-equity features, unlike the hand-written entries in ofcCoins.ts.
Extended reasoning...

The change adds nine Solana testnet tokenized-equity tokens and their nine OFC counterparts, 234 lines in two @ bitgo/statics files, with nothing removed. It touches no security-sensitive surface; it is static token configuration only. The earlier version also removed hteth:stzamakms and dropped STAKING from hteth:zamamock, but the current diff no longer touches either token. I deferred instead of approving because CODEOWNERS assigns botTokens.ts and botOfcTokens.ts to the ecosystem team.

Match the hand-written ofcCoins.ts convention and AMS's documented
intent (generated OFC fullNames must not carry the ofc prefix). The
bot's amsCi list emits 'ofc' + <name>; a follow-up with the AMS team
should strip it there so future regenerations stay clean.

Ticket: STONKS-767

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I re-reviewed the latest push and found no new bugs. Both issues I raised earlier are fixed: hteth:stzamakms (and its OFC variant) and CoinFeature.STAKING on hteth:zamamock are back, and the diff now only adds lines. Other reviewers have left inline threads on botOfcTokens.ts, and these files have a CODEOWNER, so a human should still sign off.

What was reviewed:

  • All 9 tsol:*go and 9 ofctsol:*go entries. I checked for collisions: each name and UUID shows up only in its own new entry.
  • Each OFC entry has the same name, decimals (9) and asset as its base token. Argument order matches the tsolToken/tofcsolToken entries next to them.
  • 'tokenized-equity' and 'bitgo-tokenized-equity' are existing CoinFeature values in base.ts. The mint address is the same in both address fields, and every entry uses Token2022ProgramId.
Extended reasoning...

The change adds 234 lines and deletes none: nine Solana testnet tokenized-equity tokens in modules/statics/src/coins/botTokens.ts and their nine OFC variants in botOfcTokens.ts. It doesn't touch any security-sensitive surface like auth, crypto or injection, only static token config. Both files are owned by a CODEOWNER team. Two other reviewers left inline comments on botOfcTokens.ts, and their content isn't visible here, so I can't confirm the later commit addressed them. That rules out approval.

@zeeshanamjad-eng
zeeshanamjad-eng merged commit 287fe2c into master Nov 3, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants