Repository navigation
feat(statics): add 9 goStocks test tokens from AMS - #10116
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
|
|
|
@claude review always |
|
Claude finished @zeeshanamjad-eng's task in 32s —— View job Review of #10116 (AMS token onboarding)Scope: I did not run the test suite. My local checkout's Issue (likely test failure)
Other notes
I can't submit a formal review or approve. |
Add the tsol:*go test goStocks (aaplgo, amzngo, googlgo, metago, msftgo, nvdago, spcxgo, spygo, tslago) and their ofctsol: OFC variants, as generated by the asset-metadata-service bot. Static ids match the AMS test records. The bot's regeneration also dropped hteth:WBTC, hteth:tgku, hteth:stzamakms (and OFC variants) and STAKING on hteth:zamamock, which were restored by hand in c47296c. Those unrelated changes are left out here so master's entries stay intact. Ticket: STONKS-767
4e458e3 to
50a78cc
Compare
There was a problem hiding this comment.
I reviewed the updated version and didn't find any bugs. The diff now only adds tokens and no longer removes or edits existing ones. Both files belong to the statics code owners, so their review is still needed.
What was reviewed:
- The nine new
tsol:*goentries in botTokens.ts. Their names, UUIDs and mint addresses don't clash with the existingtsol:stg*gotokens in solTokens.ts. They also set TOKENIZED_EQUITY together with BITGO_TOKENIZED_EQUITY, which the base.ts validation requires. - The matching
ofctsol:*goentries in botOfcTokens.ts. Leaving featuresundefinedmatches every other bot-generated OFC token. None of them sets tokenized-equity features, unlike the hand-written entries in ofcCoins.ts.
Extended reasoning...
The change adds nine Solana testnet tokenized-equity tokens and their nine OFC counterparts, 234 lines in two @ bitgo/statics files, with nothing removed. It touches no security-sensitive surface; it is static token configuration only. The earlier version also removed hteth:stzamakms and dropped STAKING from hteth:zamamock, but the current diff no longer touches either token. I deferred instead of approving because CODEOWNERS assigns botTokens.ts and botOfcTokens.ts to the ecosystem team.
Match the hand-written ofcCoins.ts convention and AMS's documented intent (generated OFC fullNames must not carry the ofc prefix). The bot's amsCi list emits 'ofc' + <name>; a follow-up with the AMS team should strip it there so future regenerations stay clean. Ticket: STONKS-767
There was a problem hiding this comment.
I re-reviewed the latest push and found no new bugs. Both issues I raised earlier are fixed: hteth:stzamakms (and its OFC variant) and CoinFeature.STAKING on hteth:zamamock are back, and the diff now only adds lines. Other reviewers have left inline threads on botOfcTokens.ts, and these files have a CODEOWNER, so a human should still sign off.
What was reviewed:
- All 9 tsol:*go and 9 ofctsol:*go entries. I checked for collisions: each name and UUID shows up only in its own new entry.
- Each OFC entry has the same name, decimals (9) and asset as its base token. Argument order matches the tsolToken/tofcsolToken entries next to them.
- 'tokenized-equity' and 'bitgo-tokenized-equity' are existing CoinFeature values in base.ts. The mint address is the same in both address fields, and every entry uses Token2022ProgramId.
Extended reasoning...
The change adds 234 lines and deletes none: nine Solana testnet tokenized-equity tokens in modules/statics/src/coins/botTokens.ts and their nine OFC variants in botOfcTokens.ts. It doesn't touch any security-sensitive surface like auth, crypto or injection, only static token config. Both files are owned by a CODEOWNER team. Two other reviewers left inline comments on botOfcTokens.ts, and their content isn't visible here, so I can't confirm the later commit addressed them. That rules out approval.
Summary
Adds the 9 goStocks test tokens and their OFC variants to
@bitgo/statics, as generated by asset-metadata-service:tsol:aaplgoofctsol:aaplgoebd4f8c4-41f6-49e4-abed-e778db097e355dfa6d71-171a-4b9c-99ca-b972642fdc9ctsol:amzngoofctsol:amzngo0bfa0bae-a7ff-4409-bd7f-f85415b313b602a72155-dae9-4f19-ac42-bde418efb7cctsol:googlgoofctsol:googlgo6576c5c9-0de9-4c35-be25-fe34019043ebfa55324e-00fa-4887-bc00-2319af2e50datsol:metagoofctsol:metago2e614fad-abd8-4771-8a23-79e7381cd56c26f59535-10e1-4d5f-9af3-956058a12b53tsol:msftgoofctsol:msftgo9ed5bb47-44f5-475a-b837-06ce43b3eeaa7e92c72d-9cd3-4cd2-b330-2a784e2c7560tsol:nvdagoofctsol:nvdago7c631f99-b96c-4c5d-adcf-578ef568c2f5f6856f72-1523-4bef-8613-dbd71f8ca9b8tsol:spcxgoofctsol:spcxgo990356b5-2726-481a-8a3d-27168c39b5dbfcf9ca79-7af8-425f-8887-351862bb9ce5tsol:spygoofctsol:spygo4efcd041-62a4-46ce-9425-f6d584782adba268defe-db02-4089-9198-f707a04e21bftsol:tslagoofctsol:tslago9fafac49-fc1a-4e96-8a38-45d55a8443951b816f29-548d-469f-807d-341b9c7f70e8Solana Token-2022, 9 decimals, features
tokenized-equity+bitgo-tokenized-equity. Ids match the AMS test records, so statics and AMS agree on every asset id.OFC fullNames use the clean form (
Test NVIDIA, notofcTest NVIDIA), matching the hand-writtenofcCoins.tsconvention and AMS's documented intent. The bot'samsCisource emits theofcprefix; stripping it belongs in the AMS list/generator (follow-up).Trimmed from the bot output
The bot's regeneration also removed
hteth:WBTC,hteth:tgku,hteth:stzamakms(and their OFC variants) andSTAKINGonhteth:zamamock. Those were restored by hand in c47296c and their removal broke two statics unit tests. This PR now contains only the 18 goStock entries (added verbatim from the bot output); master's other entries are untouched. Root cause is being raised with the AMS team.Verification
prettier --checkclean,tsc --buildclean@bitgo/staticsunit tests: 41,937 passing / 0 failinghteth:zamamockSTAKING are still presentTicket: STONKS-767