docs: fix the transaction store prefix and the output rows in the schema - #263
Open
artofbitcoin wants to merge 2 commits into
Open
artofbitcoin wants to merge 2 commits into
artofbitcoin wants to merge 2 commits into
Conversation
The transaction store uses the `T` key (TxRowKey, src/new_index/schema.rs); lowercase `t` holds the synced tip hash. Co-authored-by: Claude <noreply@anthropic.com>
add_transaction only writes the O row for spendable outputs (is_spendable skips
OP_RETURN, and fee / provably unspendable outputs on Elements), and its value is
the serialized TxOut, not {scriptpubkey}{value}. The a row is only written with
--address-search, for outputs that have an address.
Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two places in the docs describe the storage layout differently from what the indexer writes.
README.md: the transaction store is documented under the prefix
t, but raw transactions are keyed byT(TxRowKey { code: b'T', txid },src/new_index/schema.rs). Lowercasetis the synced tip hash (txstore_db.put_sync(b"t", ...)), so the README pointed readers at the wrong row.doc/schema.mdalready usesT{txid}.doc/schema.md: it says each output produces
"O{txid}{vout}" → "{scriptpubkey}{value}". Inadd_transaction:Orow is only written whenis_spendable(txo), which skipsOP_RETURNoutputs, and on Elements fee outputs and provably unspendable outputs too (src/util/transaction.rs);serialize(txout), the consensus-encoded TxOut (value first, then script), as the comment aboveadd_transactionalready says (O{txid}{index} → {txout});arow is written for every output that has an address, only when--address-searchis enabled.Docs only, no code change.