Repository navigation
Fix mobile environment labels and conversation navigation - #2838
Merged
Merged
Conversation
Issue: #2782 Agent-Task: codex/local/01a172ec-cdb4-7823-bf7d-546549ec6491
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 16 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
DoodleBears
marked this pull request as ready for review
October 25, 2026 20:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #2782 | Follow-up claim
Task:
codex/local/01a172ec-cdb4-7823-bf7d-546549ec6491.Why the change
Make environments easy to distinguish in mobile All lists and restore conversation taps that targeted Expo 58's outer wrapper instead of the app stack.
Special things to note
bd62dad0bd3b48ed3eb8d2af18e2e7a40755174d: 254 mobile test files passed / 9 skipped; 1,896 tests passed / 11 skipped. Mobile typecheck, source-policy check, release-fragment check and feature-map check passed. The wrapper-stack navigation regression failed twice before the fix; 57 focused navigation tests passed afterward. Expo Web export passed.bd62dad0bd3b: on the POCO, All Chats and Activity both opened the correct B DM; Back returned to the originating list; only B unread cleared and canonical readback kept the marker on B. Dark/default-size Chats and Activity showed the new source layout/icons. Changing B to a green lab icon updated both lists immediately without reload and left A unchanged. This is not full native acceptance: new pairing defaults, colliding-ID history, iOS, large-text/theme/accessibility and background push remain unqualified. Current head6ef4eba2f82f4173936e9b40da2bd92b4982c32dintegrates maine2cee221a; 87 focused tests, mobile typecheck and repository lint pass after integration; a subsequent formatting-only commit fixes two CLI documentation blank lines brought in by main, and full-repository format check passes. The native navigation regression now follows the existing mobile .tsx test boundary; root and mobile typechecks and its two regression tests pass. The latest main integration resolves the shared connection-test helper conflict and uses its native-module mocks; 15 focused tests and root typecheck pass. CI passed on this exact head: lint/format/typecheck/build, all three affected-test shards, iOS/Android mobile verification and isolated-Host E2E smoke. The aggregate gate passed; docs/native-module/full-suite/real-model jobs were skipped by the change plan. CodeRabbit reported a rate limit, not a fresh review. CI run. That newer integration has not been tested on the phone.Change outline
The environment picker remains editable. Existing pairings are not recolored; once all preset colors are used, new pairings reuse the least-used color. Activity reacts to icon/color edits without reopening the page.
Expo 58 mounts the app under an outer
__rootstack. The old helper returned success after dispatching to that wrapper, which does not register the conversation routes. The fix finds the owning app stack for local/cloud conversations, workspace resets and removed-source cleanup. Tests retain the native Stack reducer and now include the outer wrapper.Visual evidence and scope: the real Expo Web export opens the pairing screen, but this browser has no paired environments and reports unsupported
expo-file-system; no populated All/Activity comparison is claimed. The shared Android owner captured both lists and verified Chats/Activity taps and Back atbd62dad0bd3b; the Human authorized publishing the two cropped screenshots below. Manual appearance propagation passed; first-pair allocation is covered automatically but remains untested on the phone because both dedicated QA Hosts are already paired. Earlier screenshots in #2795 are not evidence for this patch. Updated two-Host journey.All Chats — physical Android phone
Environment icon and name share the first line with the Bot/channel title; the message preview occupies the second line.
Activity — physical Android phone
B uses a green laboratory icon and A a blue/purple laptop icon. Changing B's appearance updates Chats and Activity without reload.
Both captures: POCO / Android 16, dark theme, default text size, Chinese UI; cropped image 1220 × 2582. Tested JavaScript
bd62dad0bd3b, batchwindows-2795-r3; these are not captures of the later main integration. The floating Tools button is the development overlay. Capture provenance and limits. These are after-state captures; a matched before/after pair was not captured in this batch. QA resources have been released and the phone restored to its preceding development APK, with pairings and app data retained.