Repository navigation
fix(mobile): keep All Profiles on their routed environment - #2841
Merged
Merged
Conversation
Explicit Profile host IDs override retained outer sheet scope; group notification navigation keeps the same source. Avoid spreading reserved keys into section headers. Issue: #2782 Agent-Task: codex/local/01a172ec-cdb4-7823-bf7d-546549ec6491
|
Caution Review failedThe pull request is closed. Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Issue: #2782 Agent-Task: codex/local/01a172ec-cdb4-7823-bf7d-546549ec6491
DoodleBears
marked this pull request as ready for review
October 25, 2026 21:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #2782 | Work claim
Task:
codex/local/01a172ec-cdb4-7823-bf7d-546549ec6491.Why the change
Allow All-environment Group and member Profiles to use their explicitly routed Computer even when an outer sheet retains another Computer's scope.
Special things to note
Change outline
The existing Host session owner resolves explicit IDs without changing the global environment filter. A colliding group ID on B cannot substitute for the routed A group. No new lifecycle or authority is introduced; this short linear fix is explained here without a separate HTML explainer.
Physical Android Before / After — Chinese, default font scale
POCO Android 16. Baseline
a344c131ee77; tested source20c6ec23b357. Native APK SHA2564ad4f10897834f51cc72780b446c6936065df1698fe411274eb1a5adaf8cda1fwas rebuilt at baseline; cumulative native inputs unchanged and fresh Metro served the tested source. Status bar cropped; synthetic QA content.Before — dark: All -> B DM/Profile Message -> All -> A group header displays the cross-computer refusal and key warning.
After — dark: the exact path opens A's Group Profile and members.
After — light: same Group Profile; no light baseline was captured.
Evidence provenance and coverage limits.
The physical-device runner also verified A member Profile -> Message opens a DM containing A's marker; system Back restores the original Group Profile. Host mute affected only A's canonical roster, leaving B's same-ID group unchanged. A custom background persisted while B stayed default. Settings were restored. The SectionHeader key warning was absent in the observed UI/Metro path. Host mute does not establish FCM or phone-only quiet settings. QA resources were released; standalone development APK restored with data/pairings retained.