Skip to content

added vcf header options - #74

Open
alex-sandercock wants to merge 2 commits into
developmentfrom
vcf_header_options
Open

alex-sandercock wants to merge 2 commits into
developmentfrom
vcf_header_options

Conversation

@alex-sandercock

@alex-sandercock alex-sandercock commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator

Introduces options to the VCF conversion functions so that users can edit the reference genome and header information for the output VCF.

  • An additional fix adjusts the position information for the non-compliant SNP IDs that don't follow chrom_pos in the updog2vcf function

@alex-sandercock alex-sandercock self-assigned this Nov 10, 2026
Copilot AI lite review requested due to automatic review settings November 10, 2026 17:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

@codecov

codecov Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 81.08108% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.38%. Comparing base (f95fd56) to head (3cef186).

Files with missing lines Patch % Lines
R/madc2vcf_multi.R 73.19% 26 Missing ⚠️
R/madc2vcf_all.R 63.63% 4 Missing ⚠️
R/utils.R 93.18% 3 Missing ⚠️
R/madc2vcf_targets.R 77.77% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development      #74      +/-   ##
===============================================
- Coverage        85.30%   84.38%   -0.93%     
===============================================
  Files               22       22              
  Lines             3138     3170      +32     
===============================================
- Hits              2677     2675       -2     
- Misses             461      495      +34     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI lite review requested due to automatic review settings November 17, 2026 19:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Existing positional callers are broken because the new parameters precede verbose in three functions, and the documentation incorrectly groups the AD field under Header.

4 open issues
6 files not reviewed
  • man/dosage2vcf.Rd: Generated file
  • man/filterVCF.Rd: Generated file
  • man/madc2vcf_all.Rd: Generated file
  • man/madc2vcf_multi.Rd: Generated file
  • man/madc2vcf_targets.Rd: Generated file
  • man/updog2vcf.Rd: Generated file

Review effort: Lite

Comment thread R/madc2vcf_all.R
Comment on lines 89 to 92
others_max_close_snps = 3,
vcf_header = NULL,
reference = NULL,
verbose = TRUE){
Comment thread R/madc2vcf_multi.R
Comment on lines 71 to 75
markers_info = NULL,
ploidy = 2L,
vcf_header = NULL,
reference = NULL,
verbose = TRUE) {
Comment thread R/madc2vcf_targets.R
Comment on lines 158 to 161
collapse_matches_counts = FALSE,
vcf_header = NULL,
reference = NULL,
verbose = TRUE) {
Comment thread R/madc2vcf_targets.R
Comment on lines +31 to 34
#' - Header: the `##reference` and `##contig` lines come from `vcf_header` and/or
#' `reference`. A `##BIGrCommandLine` line with the function call is always
#' added.
#' * `AD` - `"ref,alt"` counts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants