Repository navigation
Conversation
|
I asked Nick to review this because I am a bit embroiled in a different setup for removing the trait cache |
nickpalladino
left a comment
There was a problem hiding this comment.
One thing I noticed while testing is I'm able to create nominal ontology terms with categories that have repeated values regardless of case. For example: first, first, FIRST. Then if I import observations values with First it's getting saved as FIRST. I think we need to add some validation in the ontology term creation flow for nominal terms so there isn't any ambiguity in assignment of values.
Good catch, added that functionality! |
Description
Story: BI-3053 - Nominal observations saved incorrectly to db
Additional experiment utilities and changes to experiment and append workflows in order for nominal observation value casing to match that of database ontology term
Import preview will show the casing of file EXCEPT in one case during the append workflow. If the overwrite file has the same nominal value as associated with the original observation unit and just different casing, it will not be recognized as a mutated value and the casing will match that of the database ontology.
Upon import observation value casing should match that of database ontology term
UPDATE:
Added validation for ontology term creation/update to prevent creating nominal terms with duplicate categories (case-insensitive).
Dependencies
bi-web: develop
Testing
Create a nominal observation variable with different forms of casing
Append experiment where some values for nominal variable don’t match the ontology casing
UPDATE:
Checklist: