Repository navigation
[BI-3101] Keep table headers and horizontal scrollbars on screen - #504
Open
syarnes-ufl wants to merge 3 commits into
Open
syarnes-ufl wants to merge 3 commits into
syarnes-ufl wants to merge 3 commits into
Conversation
Tables in ExpandableTable, SidePanelTableBuefy and SidePanelTable (BaseTable) now scroll inside a box capped to the space left in the window (BoundedTableMixin), with the header pinned below the main header. Opt out with :bounded="false", as the MultipleErrors modal does. - A result count above each table, e.g. "Showing 1–200 of 2,802 observation units" or "Showing all ...". - The box returns to its first row on page, page size, sort or filter change. - A floating horizontal scrollbar at the bottom of the window while the box's own is out of view, and scrollbars that stay drawn on macOS. - Page controls pin to the bottom of the window while the box is on screen but they are below it, with the same 12px gap under the scrollbar in either place. The experiment page's description and fields move into a collapsible "Experiment details" box, with Manage Experiment beside the title, and the dataset summary fits on one line with thousands separators. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Give the box the same 2em indent as the tabs and .tab-content below it, so the box, tabs, dataset summary and table share one left edge. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Result count: hide while loading and when a server page has no rows yet, say how many rows match on the page when a column filter narrows one page of server results, and keep the range within the filtered rows. - Older SidePanelTable/BaseTable path: show the result count and return to the first row when a column is sorted. - Page controls stay directly under the box (no pinning to the bottom of the window); the floating horizontal scrollbar stays. - Re-measure on window and page resize through one shared page observer instead of on every re-render; shared LayoutUtils for frame throttling and ResizeObserver. - Guard the Buefy table ref and its internal state. - StringFormatters.formatCount shared by the result count and dataset summary. - Unit tests for TableResultRange, TableResultCount and the bounded default and opt-out. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: BI-3101
Long tables pushed their header row and horizontal scrollbar off screen, so wide tables could only be scrolled sideways from the bottom of the page. This keeps both in view for every table.
Bounded scroll box (
BoundedTableMixin)v-bind:bounded="false".MultipleErrorsopts out because it already sits in a scrolling modal.ResizeObserverinLayoutUtils), for example when rows load or the experiment details collapse.BaseTable/SidePanelTableget the same behavior through equivalent CSS.Floating horizontal scrollbar (
FloatingScrollbar.vue)Result count and page controls
TableResultCountputs a line above each table, for example "Showing 1–200 of 2,802 observation units". It covers single results, "Showing all", and a column filter that narrows one page of server results. Each table passes its own record noun.Experiment page header
aria-expanded, is open by default, and works from the keyboard.StringFormatters.formatCount).Dependencies
None.
Testing
Tested in Chrome on a local stack (Beanies program, a 2,802-unit / 25,128-observation dataset).
develop. New unit tests coverTableResultRange,TableResultCount, and the bounded default and opt-out.SidePanelTable) path.Checklist:
🤖 Generated with Claude Code