Repository navigation
Conversation
Zoriot
added
⏰ medium priority
Qodana for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
f263ba6 to
f9f3d02
Compare
f9f3d02 to
1694f58
Compare
1694f58 to
34145df
Compare
Register navigator destinations through the Cloud command tree so users can open explore, continent, country, state, city, warp, build, plot system, and tutorial menus directly. Add greedy, case-insensitive destination arguments with tab suggestions, and apply navigator and warp permissions at command registration. Reuse the main menu's configured actions for direct Build, Plot System, and Tutorials commands. Share state and city destination discovery with the existing state menu logic. Remove the standalone /explore command and its alias configuration so exploring is available through /navigator explore. Closes #62
Remove /btt nav warps since /btt warp already opens the warp menu. Only register the nav build, plotsystem and tutorials subcommands when their menu item is enabled in the navigation config. Adds BuildTeamTools#getNavigationConfig so commands can read the config at registration time, before the module's own config field is set.
5704120 to
89802d7
Compare
| Region state = StateSelectorMenu.getCityStates().stream() | ||
| .filter(region -> region.getName().equalsIgnoreCase(stateName)) | ||
| .findFirst().orElse(null); | ||
| if (state == null) { |
There was a problem hiding this comment.
Is this fallback really necessary? Wouldn't it make more sense to just let the menu open but have no warps there yet? Then it's also easier to add states there in the future.
| .findFirst().orElse(null); | ||
| } | ||
|
|
||
| private static List<String> cityStateNames() { |
There was a problem hiding this comment.
Is this nav submenu only meant for the US? Otherwise it may make more sense to say province.
| } | ||
|
|
||
| private boolean hasNewYorkCityRegion(@NonNull BuildTeam team) { | ||
| private static boolean hasNewYorkCityRegion(@NonNull BuildTeam team) { |
There was a problem hiding this comment.
Is this supposed to be a seperate function?
There was a problem hiding this comment.
This file also has the 'state-issue'. Even if it's solely North America, there's still edge cases like Mexico, Saint Pierre etc.
| } | ||
|
|
||
| public MainMenu(Player menuPlayer, boolean autoLoad) { | ||
| super(3, INVENTORY_NAME, menuPlayer, autoLoad); |
There was a problem hiding this comment.
Why is the inventory slot hard-coded here? Wouldn't it make more sense to add a command to give you the nav selector? (We can also make an issue if this is out of scope).
2 participants
Register navigator destinations through the Cloud command tree so users can open explore, continent, country, state, city, warp, build, plot system, and tutorial menus directly. Add greedy, case-insensitive destination arguments with tab suggestions, and apply navigator and warp permissions at command registration.
Reuse the main menu's configured actions for direct Build, Plot System, and Tutorials commands. Share state and city destination discovery with the existing state menu logic. Remove the standalone /explore command and its alias configuration so exploring is available through /navigator explore.
Closes #62
GitHub Copilot was used for most of the implementation.