Repository navigation
Speed up CI - #32
Merged
Merged
Speed up CI#32
Conversation
doc-only PRs skip integration skip-integration label skips integration
kflemin
approved these changes
Nov 17, 2026
JieXiong9119
added a commit
that referenced
this pull request
Nov 18, 2026
commit b45ec37 Merge: 0496378 e0bb39b Author: JieXiong9119 <69597597+JieXiong9119@users.noreply.github.com> Date: Tue Nov 17 17:39:18 2026 -0700 Merge branch 'develop' into scenario-workflow commit e0bb39b Merge: 1929a26 65bb0a9 Author: Jie Xiong <jiexiong9119@gmail.com> Date: Tue Nov 17 17:30:42 2026 -0700 Merge pull request #32 from BuildingSync/speed-up-ci Speed up CI commit 65bb0a9 Author: JieXiong9119 <69597597+JieXiong9119@users.noreply.github.com> Date: Tue Nov 17 14:01:59 2026 -0700 split jobs into unit and integration, split integration into 4 shards doc-only PRs skip integration skip-integration label skips integration commit 1929a26 Merge: 871317d 711e45f Author: Katherine Fleming <2205659+kflemin@users.noreply.github.com> Date: Thu Nov 12 10:43:31 2026 -0700 Merge pull request #22 from BuildingSync/fix/floor-area-building-first Fix/floor area building first commit 711e45f Author: Katherine Fleming <2205659+kflemin@users.noreply.github.com> Date: Wed Nov 11 12:29:18 2026 -0700 fix test commit bcf2317 Author: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Date: Tue Nov 10 22:21:50 2026 +0000 Handle missing Building in floor area fallback Co-authored-by: kflemin <2205659+kflemin@users.noreply.github.com> commit 35abcbf Author: Katherine Fleming <2205659+kflemin@users.noreply.github.com> Date: Tue Nov 10 12:57:19 2026 -0700 Require logger and constants in BuildingSyncReader The reader calls BOSS.BOSS_logger and uses ASHRAE90_1 and other constants, but relied on other files to load them. Running buildingsync_reader_spec.rb on its own failed with "undefined method `BOSS_logger' for BOSS:Module". Require both directly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> commit 43fc2da Author: Katherine Fleming <2205659+kflemin@users.noreply.github.com> Date: Tue Nov 10 12:53:24 2026 -0700 Prefer Building floor area over Site get_total_floor_area checked Site FloorAreas before Building, so a Site value overrode the Building's own value. Check the more specific Building first and fall back to Site, matching the method comment. Add specs for Building only, Site only, and both present. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Speed up CI: split unit and integration tests, run simulations in parallel shards, add caching
Closes #12
Why
The single
Testsjob ran every spec in one job, including about 20 full-year EnergyPlus simulations one after another. Each run took roughly 1h15m–1h30m, even for PRs that don't touch simulation code.What changed
Workflow (
.github/workflows/ci.yml)Replaced the single
Testsjob with three jobs:unitrunsspec/tests/uniton every PR and push. It doesn't install external measures.changeschecks whether a PR changes anything besides documentation (*.md,docs/,LICENSE*).integration (shard N)runs the simulation specs as 4 parallel shards withfail-fast: false.When integration runs:
skip-integrationdevelopor a tagworkflow_dispatchPRs also trigger on
labeled/unlabeled, so adding or removingskip-integrationtakes effect right away.Added
concurrencywithcancel-in-progressso a new push cancels the outdated run.Caching:
.bundle/install, keyed onGemfile.lockand the gemspec.vendor/external_measures, keyed onconfig/external_measure_repos.yml.Added
--profile 10so the slowest tests show up in CI logs.When an integration shard fails, its
spec/outputis uploaded as an artifact.Integration spec (
spec/tests/integration/write_and_run_osws_spec.rb)BOSS_SHARDS/BOSS_SHARDselect the fixtures whereindex % BOSS_SHARDS == BOSS_SHARD. Out-of-range values raise an error.BOSS_SMOKE=1runs onlybuilding_151.xmlandexample-smalloffice-level1.xml, for quick local checks.README
Verification
rspec --dry-runfor each shard selected 5, 5, 5 and 5 fixtures: 20 in total, no duplicates, matching the full list.BOSS_SMOKE=1 --dry-runselected 2 fixtures.Follow-ups for maintainers
skip-integrationlabel.unitand theintegration (shard N)jobs instead ofTests. Skipped jobs count as passing.--profileand rebalance or move to 5 shards if one shard is much slower than the others.Notes
comstockstays onmain, as before. The cache only provides a starting checkout, andrake measures:install_externalalways fetches the latestmain. Upstream changes can still affect CI results.skip-integrationfor PRs that clearly don't touch simulations.BuildingEQ-1.0.0_gemtest.xmlsizing failure, and any change to what the tests assert or how simulations behave.