Repository navigation
L200 baseline HVAC workflow - #33
Open
JieXiong9119 wants to merge 4 commits into
Open
JieXiong9119 wants to merge 4 commits into
JieXiong9119 wants to merge 4 commits into
Conversation
Contributor
Author
|
Notes:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds L200 HVAC topology construction to the baseline: when a BuildingSync file's existing HVAC system exactly matches a supported topology, BOSS builds that topology instead of relying on
create_typical_building_from_model's generic HVAC. All other cases keep today's fallback behavior.This pulls the baseline + HVAC part of
scenario-workflowbranch (up to #30) intodevelopon its own, ahead of the package-scenario work. Scenario mapping, scenario OSW writing/running, modifier binding, and retrofit fixtures stay onscenario-workflow.Behavior
HVACSystemexactly matches one supported configuration (PTAC, PTHP, four-pipe fan coil, packaged rooftop AC/heat pump, packaged rooftop VAV or VAV with hot-water reheat, warm air furnace, VRF; optionally plus ventilation-only/DOAS with zone equipment) that serves the whole building:create_typical_building_from_modelgetsadd_hvac: falseapply_hvac_topology_to_zone_scope(create,all_model_zones) thenapply_standard_hvac_sizing_and_efficiencyare addedbuildingsync-measures-gemmeasure paths are added tomeasure_pathsadd_hvac: true, existingsystem_typemapping, a logged warning, and no dependency on the sibling checkout. Verified byte-identicalin.oswagainstdevelopforbuilding_151andall_measures_applied_example.baseline/in.oswlayout.Changes
OswArgPopulator:append_step,set_step_argument,step_argument_setter,add_hvac:keyword (defaulttrue)ExternalMeasureRepoManager+config/external_measure_repos.yml:local_pathsources (used in place, never touched by Git; missing path is an actionable error) and thescenario_only/include_scenario_onlygate so only topology baselines need../buildingsync-measures-gemBuildingSyncReader#get_hvac_systems_xmlHvacTopologySelector,BaselineHvacPlanner(incl.proposed_system_ids, moved fromScenarioHvacPlanner), andHvacTargetBinder(topology binding only;bind_modifierintentionally omitted)Boss.write_baseline_oswrefactored onto privatebuild_baseline_osw;run_baseline_oswunchangedexample-smalloffice-level2.xml,example-smalloffice-level2-built-2012.xmlbuildingsync-measures-gemas a sibling at the pinned ref in the unit and integration jobs; paths/caches/artifacts adjusted for theBOSS/subfolder. Shards, smoke selection, and docs-only gates unchanged.BOSS_SMOKE=1add_hvacrow updatedTesting
bundle exec rspec spec/tests/unit— 152 examples, 0 failuresdevelop(building_151,all_measures_applied_example) — identicalbundle exec rake measures:install_external+rspec spec/tests/integration/write_and_run_osws_spec.rb -e "topology HVAC baseline"— 2 examples, 0 failures (both simulationsSuccess)git diff --check— cleanLocal setup
Only needed for topology baselines and the related specs.