Repository navigation
Conversation
- Protect internal node/link properties during CSV, Excel and JSON imports. - Preserve conflicting metadata under reusable "(Imported)" aliases while keeping canonical structural values authoritative. - Display exact field keys throughout selectors, tables, tooltips and views. - Separate internal options from real fields named None or other sentinel values. - Safely handle prototype-sensitive keys, header whitespace and duplicate CSV headers. - Add collision fixtures and unit/end-to-end coverage; update Cypress expectations and stabilize shared dropdown helpers. Validation: - 82 focused unit tests and development build passed. - Cypress: 622 passed, 6 preexisting failures, 5 pending, 14 skipped across 173 specs. - All six remaining failures reproduced on the baseline revision. Fixes CDCgov#1719
Preserve collision-safe field selection alongside the Sigma renderer migration, layout changes, and updated link defaults. Decode composition fields without trimming exact keys or confusing real None metadata with internal options. Resolve the Cytoscape collection type mismatch and adapt collision checks for either renderer. Validation: 146 focused Angular unit tests passed; development build passed with size-budget warnings. Cypress was not run.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent imported metadata from overwriting MicrobeTrace’s internal node/link properties. This addresses missing or altered values in Map and Table when uploaded columns use names such as
_jlat,id,seq, orsize.Fixes #1719
Changes
(Imported)aliases, adding numeric suffixes only when necessary.Nonefrom internal “no field” options and other synthetic choices.Compatibility
Existing sessions remain loadable without migration. New collision aliases persist in saved sessions. Reserved-header remapping applies to tabular node/link imports; network-document importers retain their format-specific handling.