Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
Collaborator
Author
|
Closing – applying recommendations |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Documentation, Other
Description
Remove unused Suricata testing shell scripts
Update README for v1.0.0-dev pre-release
Add memory reallocation item to ISSUES.md
Diagram Walkthrough
File Walkthrough
configs.sh
Delete unused Suricata config generation scriptsrc/configs.sh
runs.sh
Delete unused Suricata test runner scriptsrc/runs.sh
logic
ISSUES.md
Add memcap reallocation future work itemISSUES.md
reached
README.md
Update README prerequisites and warnings for v1.0.0-devREADME.md
v1.0-devtov1.0.0-devSystemsection requiring NUMA-bound network interfaceSuricata configuration filesection with memcap warningcpu_affinitymodule supports only a singleinterface