Update sass and add venv to git ignore - #145
Merged
Merged
Conversation
|
LGMT. Have another eng approve before Merge. |
JamesDemeryNava
approved these changes
Sep 28, 2026
JamesDemeryNava
left a comment
JamesDemeryNava
left a comment
Contributor
There was a problem hiding this comment.
Had to run yarn install in client before seeing 1.105.0, but after doing that it worked! Nice job.
JamesDemeryNava
approved these changes
Sep 28, 2026
JamesDemeryNava
left a comment
JamesDemeryNava
left a comment
Contributor
There was a problem hiding this comment.
Good call adding the yarn.lock files! Looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BB2-5213
What Does This PR Do?
Upgrade sass to version 1.79.0 or higher. I also added venv to git ignore for pre-commit to work properly for me.
What Should Reviewers Watch For?
If you're reviewing this PR, please check for these things in particular:
Validation
docker compose updocker exec -it <docker-container-id> /bin/shyarn why sassand see that it is version 1.105.0