Repository navigation
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Collaborator
Coverage Report for CI Build 42186137171Coverage remained the same at 0.0%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implicitly nullable parameter types (
string $x = null) are deprecated since PHP 8.4. This makes them explicit in the 0.4.x line, which is the one that still supports TYPO3 11.5 and 12.4.mainalready contains the same fix.MailqueueModuleController::resolveTemplateVariables():$sendIdand$deleteIdare now?stringBehavior is unchanged and the signature is valid on PHP 8.1 and newer.
Checks:
composer lintpassescomposer sca: 6 -> 4 errors. The two removed errors are the "Deprecated in PHP 8.4" reports for these parameters; the remaining 4 also occur on unmodified 0.4.xcomposer test: no tests in the repositoryA 0.4.6 release would be needed for projects on TYPO3 12.