Skip to content

[TASK] make implicit nullable parameter types explicit for PHP 8.4 on TYPO3 v12.4.x - #381

Open
cyberelk wants to merge 1 commit into
0.4.xfrom
feature/php84-implicit-nullable
Open

cyberelk wants to merge 1 commit into
0.4.xfrom
feature/php84-implicit-nullable

Conversation

@cyberelk

@cyberelk cyberelk commented Nov 6, 2026

Copy link
Copy Markdown

Implicitly nullable parameter types (string $x = null) are deprecated since PHP 8.4. This makes them explicit in the 0.4.x line, which is the one that still supports TYPO3 11.5 and 12.4. main already contains the same fix.

  • MailqueueModuleController::resolveTemplateVariables(): $sendId and $deleteId are now ?string

Behavior is unchanged and the signature is valid on PHP 8.1 and newer.

Checks:

  • composer lint passes
  • composer sca: 6 -> 4 errors. The two removed errors are the "Deprecated in PHP 8.4" reports for these parameters; the remaining 4 also occur on unmodified 0.4.x
  • composer test: no tests in the repository

A 0.4.6 release would be needed for projects on TYPO3 12.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@coveralls

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 42186137171

Coverage remained the same at 0.0%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 718
Covered Lines: 0
Line Coverage: 0.0%
Coverage Strength: 0.0 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants