Repository navigation
Harden /webSearch query validation and reject regex operators - #194
Open
afoote-mitre wants to merge 1 commit into
Open
afoote-mitre wants to merge 1 commit into
afoote-mitre wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validate the complete
/webSearchexpression before contacting OpenSearch, reject regex operators, and distinguish unsupported client syntax from backend failures. Ordinary multi-term searches, phrases, supported Boolean expressions, wildcards, and standalone date/range searches remain supported.Why These Changes Were Needed
query_string. Validation now checks quotes, escapes, and grouping and cannot be overridden by a valid trailing token.utils/webSearchQueryBuilder.jsutils/webSearchQueryBuilder.jsWEB_SEARCH_QUERY_SYNTAXin the existingsearchMetadata.errorsenvelope without calling OpenSearch. Backend failures and timeouts retain their sanitized HTTP 502/504 handling.controllers/searchController.js,utils/errors.jsutils/webSearchQueryBuilder.jsREADME.md,routes/index.js,api-docs/openapi.json,api-docs/openapi.test.jsutils/webSearchQueryBuilder.test.js,controllers/searchController.test.js,routes/search.integration.test.js,utils/errors.test.jsScope
/webSearch;/searchis unchanged.query_stringwith anANDdefault operator. Sorting, pagination, and the response envelope are retained.