Repository navigation
fix: 시드 밖 계정의 시드 상품 주문이 재시드를 막던 문제 수정 #536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When retrying after the original failure, this predicate is never reached because the entire order-cleanup block remains guarded by
userIds.length > 0. The previous non-transactional reset deletes the seed users before reaching product deletion, where an outsider's order item causes the FK failure; consequently, the database state this fix must recover has seed stores and the blocking order but no seed users. A subsequent seed attempt still skips this query and fails at product deletion again, requiring manual cleanup instead of restoring idempotency. Move the seed-store order cleanup outside the user-only guard (while retaining user-specific cleanup separately).Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
반영: 주문 정리 블록을
userIds.length > 0밖의 별도 블록(userIds.length > 0 || storeIds.length > 0)으로 이동. 시드 사용자 계정은 1) 끝에서 지워지고 실패는 2) 상품 삭제에서 나므로, 이미 한 번 실패한 DB(시드 사용자 없음 + 시드 매장·막는 주문 잔존)가 이번 수정으로도 복구되지 않던 경로가 맞음. 시드 매장만 있는 상태 재현 테스트 추가.