Skip to content

refactor: rate-limit 배럴에서 쓰이지 않는 RateLimitPolicy export 제거 - #543

Merged
chanwoo7 merged 1 commit into
developfrom
refactor/rate-limit-barrel-export
Oct 22, 2026
Merged

chanwoo7 merged 1 commit into
developfrom
refactor/rate-limit-barrel-export

Conversation

@chanwoo7

Copy link
Copy Markdown
Member

개요

knip 리포트에 남아 있던 유일한 항목(Unused exported types: RateLimitPolicy)을 정리합니다.

  • src/global/rate-limit/index.ts 배럴이 RateLimitPolicy 타입을 다시 내보내지만, 이 배럴로 그 타입을 가져가는 곳은 없습니다.
  • 실제 사용처인 rate-limit.decorator와 rate-limit.guard는 rate-limit.guard에서 직접 import하므로 동작 변경은 없습니다.

검증

  • yarn knip: 제거 전 1건(종료 코드 1), 제거 후 0건(종료 코드 0)
  • tsc·lint 통과, pre-push 전체 jest(388개 스위트 4,315건) 통과

플랜 대조

항목(사용자 요청: knip 지적을 별도 PR로 정리) 상태
RateLimitPolicy 배럴 export 제거 한 것

knip 리포트의 유일한 항목. 배럴로 RateLimitPolicy를 가져가는 곳이 없고 decorator·guard는 rate-limit.guard에서 직접 import함.

- 검증: yarn knip 0건(제거 전 1건), tsc 통과
@coderabbitai

coderabbitai Bot commented Oct 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-22T13:23:49.688701Z 9fa3fa7 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

🧹 knip — dead-code 리포트

요약 항목 없음
전체 리포트
(knip 출력 없음 — 이슈 0이거나 실행 실패)

청소 후보(오탐 가능) · 기준 docs/guide/architecture-conventions.md

@github-actions

Copy link
Copy Markdown

🩺 NestJS Doctor — 90/100 (Excellent)

진단 493건 (error 13).

Category error warning info
architecture 1 1 44
correctness 0 269 0
performance 0 41 28
schema 0 0 76
security 12 21 0
architecture / security 상위 항목
  • error security/security/no-hardcoded-secrets: Variable 'SEED_PASSWORD' appears to contain a hardcoded secret.
  • error architecture/architecture/no-manual-instantiation: Manual instantiation of 'OutboxRepository' detected. Use dependency injection instead.
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal type 'IAuditLogRepository'.
  • warning security/security/no-exposed-env-vars: Direct 'process.env.NODE_ENV' access in 'AuthController'. Use ConfigService instead.
  • warning security/security/require-guards-on-endpoints: Endpoint 'start' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'callback' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'refresh' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'logout' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'sellerLogin' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'sellerRefresh' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'sellerLogout' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'devIssueToken' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'adminLogin' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'adminRefresh' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'adminLogout' has no @UseGuards() at class or method level.

오탐 포함 가능 · 기준 docs/guide/architecture-conventions.md

@github-actions

Copy link
Copy Markdown

Coverage report

St.❔
Category Percentage Covered / Total
🟢 Statements
98.02% (+0.01% 🔼)
10805/11023
🟢 Branches
92.96% (+0.02% 🔼)
4120/4432
🟢 Functions 97.56% 2155/2209
🟢 Lines 98.6% 9828/9968

Test suite run success

4314 tests passing in 388 suites.

Report generated by 🧪jest coverage report action from 9fa3fa7

@chanwoo7
chanwoo7 merged commit 758038b into develop Oct 22, 2026
17 checks passed
@chanwoo7
chanwoo7 deleted the refactor/rate-limit-barrel-export branch October 22, 2026 13:27
@codecov

codecov Bot commented Oct 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant