Repository navigation
docs: curate AGENTS.md back under budget (6199 -> 5887) - #139
Merged
Merged
Conversation
Three Bus Conventions bullets pruned as duplicates, each read against a destination that already states every fact at length (judged entries in .skills/context-loss-ok): - Two blob backends, one seam -> docs/STORAGE.md ## Two backends, one seam - The replicate loop writes for gcs (#29) -> docs/CONVENTIONS.md, docs/STREAMS.md - Watcher alone issues content.fetch (#90) -> docs/STREAMS.md prove-no-loss: lost 0, warranted 10, claims dropped 0. Seams 0 (4 new back-references acknowledged), counts 0 (one stale ack pruned). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Fresh-eyes review: a coding rule anyone adding a BlobStore call in src/worker/ needs, and the off-loop test pins only the call sites it names. Restored as one bullet with the STORAGE.md pointer, verbatim. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings
AGENTS.mdback under its 6,000-token budget.931ddbfpushed it to 6,199 when it added Design Preferences, and it was already 5 over before that.931ddbf)c95aa3f)Per-section disposition
to_threadrule restored as one line; the rest kept inline931ddbfDeletions and their warrants
Each is a
duplicatewarrant, following the #72 precedent: the destination already states every fact at length, so a verbatim move would have put a near-duplicate beside the canonical text, which Phase 5 forbids. The removed lines (9 after CR 1) are judged entries in.skills/context-loss-ok, each with what it was read against.docs/STORAGE.md→ Two backends, one seam:REPLICATOR_BLOB_BACKEND, thefile:///gs://table, "local is the default and stays the default", the boldasyncio.to_threadrulegcs(#29)docs/CONVENTIONS.md:45(create-if-absent, "never resolved as a path");docs/STREAMS.md'scontent.replicatebulletcontent.fetch(#90)docs/STREAMS.md's Watcher bullet:seed_fetch.pyseeds scratch streams,--production, Watcher's identityGates
prove-no-loss.sh --base 931ddbf --claims: lost 0, warranted 9, claims dropped 0. The 2 lines found duplicated are the two commands that also appear inCOMMANDS.md; that duplication was already there.check-seams.sh: 0 left after acknowledging 4. Three are back-references to sections that stay inline (Common Commands, Design Preferences). The fourth is a heading that carries an issue number,COMMANDS.md's "in-flight count (OS patching under the patching-hosts skill: first run on co-replicator (vendor the skill, commit the knob, maintenance-lane catch-up) for gregoryfoster/skills#313 step 8b #131)", which this run didn't add and which no link targets.check-counts.sh: 0. Pruned one acknowledgement this run made stale.uv run pytest: 1403 passed. The worktree skips 6 tests where the main checkout skips 1, because the untracked.claude/settings.local.jsonis absent here and the exe.dev session check fails. Ruff is clean..skills/context-metrics.jsonl(skill v1.31).Fresh-eyes review (CR 1)
A reviewer subagent with no context from this session confirmed every removed fact is in its destination and checked that each acknowledgement entry matches what it claims. It made one judgment call, which is adopted in
c95aa3f: keep "EveryBlobStorecall from a coroutine goes throughasyncio.to_thread" inline. Anyone adding a store call insrc/worker/needs it, and the off-loop test pins only the call sites it names. The Watcher/--productiondemotion was judged safe: the broker ACL, the script's--productiongate and the absence of Watcher credentials each stop it. The telemetry row was rewritten with--amend(5887 → 5955).The reviewer also noted cosmetic drift, which this PR leaves alone: STREAMS.md:3, CONVENTIONS.md:4 and the AGENTS.md index line for STREAMS.md describe those docs as "one bullet per rule AGENTS.md states in a line". That was never strictly one-to-one, and it is now looser by two rules.
Not in scope
.skills/context-loss-okandcontext-claims-okhold many entries from earlier runs that now match nothing, and the script lists them for pruning. That clean-up is its own pass.docs/SKILLS.md(10,089),COMMANDS.md,DEPLOYMENT.mdandENVIRONMENT.mdare over the 10k per-doc budget. That was true before this run, which made none of them bigger.🤖 Generated with Claude Code