Repository navigation
Fix fleet queue wedge: reap expired cancel-requested leases - #166
Merged
Merged
Conversation
claim() now resolves cancel-requested leases whose owners never acknowledged teardown to cancelled once the lease expires, freeing capacity. Valid cancel-requested leases still hold capacity. Regression test: expired cancel-requested lease resolves without its owner; live-verified on rsi-train-20261013 (job 6684468d).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #165.
Root cause: cancel-requested leases were excluded from the expiry reaper in claim() but fenced out of complete()/fail()/heartbeat(), so a dead owner left the job leased+cancel-requested forever, holding capacity.
Fix: claim() now resolves cancel-requested leases to cancelled once the lease expires (error preserves the cancel reason plus an expiry note). Valid cancel-requested leases still hold capacity; acknowledgeCancellation stays the fast path for live owners.
Evidence: